From: "Z.q. Hou" <zhiqiang.hou@nxp.com>
To: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
        "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "computersforpeace@gmail.com" <computersforpeace@gmail.com>,
        "dwmw2@infradead.org" <dwmw2@infradead.org>,
        "boris.brezillon@free-electrons.com" 
        <boris.brezillon@free-electrons.com>,
        "marek.vasut@gmail.com" <marek.vasut@gmail.com>,
        "richard@nod.at" <richard@nod.at>
Subject: RE: [PATCH 2/2] mtd: m25p80: restore the addressing mode when stop
 using the flash
Thread-Topic: [PATCH 2/2] mtd: m25p80: restore the addressing mode when stop
 using the flash
Thread-Index: AQHTZQ7YcsqLTW747k+L9XiNGCA726MuOskAgAASntA=
Date: Fri, 1 Dec 2017 10:06:29 +0000
Message-ID: <AM5PR0402MB2771E30AB082C9AB415A55A784390@AM5PR0402MB2771.eurprd04.prod.outlook.com>
References: <20171124100848.1828-1-Zhiqiang.Hou@nxp.com>
 <20171124100848.1828-3-Zhiqiang.Hou@nxp.com>
 <b21e0615-9a64-7dc5-cbb2-f391a640273d@wedev4u.fr>
In-Reply-To: <b21e0615-9a64-7dc5-cbb2-f391a640273d@wedev4u.fr>
Accept-Language: zh-CN, en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5f1b50bc-e46a-45a6-0019-08d538a33128
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2017 10:06:29.7697
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2771
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id vB1A6feR004714
Content-Length: 1426
Lines: 48

Hi Cyrille,

Thanks for your comments!

> -----Original Message-----
> From: Cyrille Pitchen [mailto:cyrille.pitchen@wedev4u.fr]
> Sent: 2017年12月1日 16:58
> To: Z.q. Hou <zhiqiang.hou@nxp.com>; linux-mtd@lists.infradead.org;
> linux-kernel@vger.kernel.org; computersforpeace@gmail.com;
> dwmw2@infradead.org; boris.brezillon@free-electrons.com;
> marek.vasut@gmail.com; richard@nod.at
> Subject: Re: [PATCH 2/2] mtd: m25p80: restore the addressing mode when
> stop using the flash
> 
> Hi Hou,
> 
> Le 24/11/2017 à 11:08, Zhiqiang Hou a écrit :
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >
> > Add .shutdown function to restore the addressing mode in reboot
> > process, and add the same operation to the .remove function.
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > ---
> >  drivers/mtd/devices/m25p80.c | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/mtd/devices/m25p80.c
> > b/drivers/mtd/devices/m25p80.c index dbe6a1de2bb8..867bd2d5a267
> 100644
> > --- a/drivers/mtd/devices/m25p80.c
> > +++ b/drivers/mtd/devices/m25p80.c
> > @@ -307,10 +307,17 @@ static int m25p_remove(struct spi_device *spi)
> > {
> >  	struct m25p	*flash = spi_get_drvdata(spi);
> >
> > +	spi_nor_restore_addr_mode(&flash->spi_nor);
> 
> maybe add a new line here.
> 
> Otherwise, this looks good :)

Yes, will add in next version, thanks a lot for the suggestion!


Thanks,
Zhiqiang