Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752359AbdLALLP (ORCPT ); Fri, 1 Dec 2017 06:11:15 -0500 Received: from mail-eopbgr30085.outbound.protection.outlook.com ([40.107.3.85]:32608 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752310AbdLALLK (ORCPT ); Fri, 1 Dec 2017 06:11:10 -0500 From: Oleksandr Shamray To: "'Kun Yi'" CC: "gregkh@linuxfoundation.org" , "arnd@arndb.de" , system-sw-low-level , "devicetree@vger.kernel.org" , "jiri@resnulli.us" , Vadim Pasternak , "linux-api@vger.kernel.org" , OpenBMC Maillist , "linux-kernel@vger.kernel.org" , "openocd-devel-owner@lists.sourceforge.net" , "mec@shout.net" , Jiri Pirko , "robh+dt@kernel.org" , "linux-serial@vger.kernel.org" , "tklauser@distanz.ch" , "mchehab@kernel.org" , "davem@davemloft.net" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [patch v12 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx families JTAG master driver Thread-Topic: [patch v12 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx families JTAG master driver Thread-Index: AQHTXWmOxItJNl+A6E2rCoN3qQNgbaMsDkYAgAJRjSA= Date: Fri, 1 Dec 2017 11:11:03 +0000 Message-ID: References: <1510675867-24276-1-git-send-email-oleksandrs@mellanox.com> <1510675867-24276-3-git-send-email-oleksandrs@mellanox.com> In-Reply-To: Accept-Language: en-US, uk-UA Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=oleksandrs@mellanox.com; x-originating-ip: [82.166.227.17] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR05MB3342;6:v2MXQolWbFEAPlL/FrDJVX69OM5QUzQhLLL5Ji++10iMrol1v3ACfqwhYQ0CaX9OB8/FE8Qf6UMcgt8djxxb+1rwNi7kQ2cEKy5X1+DBbwOymJfJcggq75SF0LI6ZAQN47ePOILDT7BVv68cGeJQUg0OoMsQfiBbhrQj8MOO+2XfxXuLPCJlrCNSpkz61Qw9NnsB45/Tqx14idEqItAlbHj7ItmyskwiBfHsEMaWcdIuAnwfWlLdfKnBIC8wFgSR0awvEEfNdMTibZwmj+vWytif+zY+kRll4DZStPYP6hXR7HvxaQkOWFia3H4xyY8ml+z/UAx2fFn/ZTQsFMJgTryGHKbZMpshlUaHidVkNYs=;5:fq0S+WUDecvfScpfnGAHRLarAZ61ODuaHD2yDbIHHURFFDerJu07RthNqZFw1e9QVN7jxd71CCEHjYTqVofH8YrWCvjezlZhjRxreHgJgGv2ZlHcMv/bO3A9EZ7yXYtPDEoRaRVlD0yTRTj08uvVWJOB5Fzon2FgcvDvackPPdQ=;24:ZsBGnh4z6UHiGaH2cuF3P0whuQqYyxZCidc646EZfoXmD000ce2eYEHQtTpMzVrpJNrrxelmrW4q8Amo0j9E3wEiW6J3JevEPmtY1E4z7lY=;7:zA9niZWZ2w2tOQRnNX9BZCk9NFoubZvbuLMppPCZctY/vuytyA0kIYbobsQyTFFWhx4EOVleKYUzT6GvWgBjmNrsitooQ/kV7GRvBT+9nLpi9jenyx7hGukDS4n6e74/4T+fC2/0e6738FfR6rl0qLjoEj7DtVg4609iYR0+e/OjBHMy9g05TeoFMtp85f0ILG8JAL0ZqP3bmCt/qGqH+qwMyoVUFSDNH3ndoIzK+eUNx4CKXwg3JJbuOvEtSD56 x-ms-exchange-antispam-srfa-diagnostics: SSOS;SSOR; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: f035c66a-8549-4ddc-a553-08d538ac365c x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(48565401081)(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603286);SRVR:VI1PR05MB3342; x-ms-traffictypediagnostic: VI1PR05MB3342: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(143289334528602)(9452136761055)(65623756079841)(258649278758335)(211936372134217)(42262312472803); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231022)(920507027)(6055026)(6041248)(20161123560025)(20161123562025)(201703131423075)(201703011903075)(201702281528075)(201703061421075)(20161123558100)(20161123564025)(20161123555025)(6072148)(201708071742011);SRVR:VI1PR05MB3342;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:VI1PR05MB3342; x-forefront-prvs: 05087F0C24 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(6009001)(7966004)(376002)(366004)(346002)(39860400002)(199003)(13464003)(24454002)(189002)(34040400001)(7696005)(53546010)(66066001)(2950100002)(6436002)(5660300001)(14454004)(7416002)(229853002)(6506006)(2906002)(68736007)(99286004)(76176011)(9686003)(97736004)(25786009)(6916009)(54906003)(2900100001)(6246003)(3280700002)(305945005)(86362001)(4326008)(81156014)(105586002)(102836003)(316002)(74316002)(8676002)(189998001)(53936002)(33656002)(7736002)(81166006)(6116002)(3660700001)(55016002)(106356001)(101416001)(508600001)(8936002)(54356011)(3846002)(5250100002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR05MB3342;H:AM4PR0501MB2194.eurprd05.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: f035c66a-8549-4ddc-a553-08d538ac365c X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Dec 2017 11:11:03.9271 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB3342 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vB1BBIJM020182 Content-Length: 2499 Lines: 84 > -----Original Message----- > From: Kun Yi [mailto:kunyi@google.com] > Sent: Thursday, November 30, 2017 12:51 AM > To: Oleksandr Shamray > Cc: gregkh@linuxfoundation.org; arnd@arndb.de; system-sw-low-level > ; devicetree@vger.kernel.org; > jiri@resnulli.us; Vadim Pasternak ; linux- > api@vger.kernel.org; OpenBMC Maillist ; linux- > kernel@vger.kernel.org; openocd-devel-owner@lists.sourceforge.net; > mec@shout.net; Jiri Pirko ; robh+dt@kernel.org; linux- > serial@vger.kernel.org; tklauser@distanz.ch; mchehab@kernel.org; > davem@davemloft.net; linux-arm-kernel@lists.infradead.org > Subject: Re: [patch v12 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx > families JTAG master driver > > Thanks for working on the driver, Oleksandr. I gave this a try on a board with > Aspeed 2520. One question below: > > On Tue, Nov 14, 2017 at 8:11 AM, Oleksandr Shamray > wrote: > > Driver adds support of Aspeed 2500/2400 series SOC JTAG master controller. > > > > Driver implements the following jtag ops: > > - freq_get; > > - freq_set; > > - status_get; > > - idle; > > - xfer; > > [..] > > + > > +static const struct jtag_ops aspeed_jtag_ops = { > > + .freq_get = aspeed_jtag_freq_get, > > + .freq_set = aspeed_jtag_freq_set, > > + .status_get = aspeed_jtag_status_get, > > + .idle = aspeed_jtag_idle, > > + .xfer = aspeed_jtag_xfer, > > + .mode_set = aspeed_jtag_mode_set }; > > + > > +static int aspeed_jtag_probe(struct platform_device *pdev) { > > + struct aspeed_jtag *aspeed_jtag; > > + struct jtag *jtag; > > + int err; > > + > > + if (!of_device_is_compatible(pdev->dev.of_node, > > + "aspeed,aspeed-jtag")) > > Should this be "aspeed,ast2400-jtag"/"aspeed,ast2500-jtag" as specified in the > compatible string below? > Yes > > + return -ENOMEM; > > + > > + jtag = jtag_alloc(sizeof(*aspeed_jtag), &aspeed_jtag_ops); > > + if (!jtag) > > + return -ENODEV; > > + > > + platform_set_drvdata(pdev, jtag); > > + aspeed_jtag = jtag_priv(jtag); > > + aspeed_jtag->dev = &pdev->dev; > > + [..] > > + > > +MODULE_AUTHOR("Oleksandr Shamray "); > > +MODULE_DESCRIPTION("ASPEED JTAG driver"); MODULE_LICENSE("GPL > v2"); > > -- > > 1.7.1 > > > -- > Regards, > Kun Thanks. BR Oleksandr Shamray