Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752196AbdLAMDf (ORCPT ); Fri, 1 Dec 2017 07:03:35 -0500 Received: from mail-lf0-f66.google.com ([209.85.215.66]:45122 "EHLO mail-lf0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751385AbdLAMDd (ORCPT ); Fri, 1 Dec 2017 07:03:33 -0500 X-Google-Smtp-Source: AGs4zMbPFStheQjaQUPVWHn0IIj566Sn/mI5SEL4LIeh2kdyXawxrZhSPv2dRbZCzlI2tlOIZ41K5oP0p+V/pa3jFK8= MIME-Version: 1.0 In-Reply-To: References: <20171114123834.xsjiy2ynvott4gae@brain> <1511780854-7213-1-git-send-email-paolo.pisati@canonical.com> From: Riku Voipio Date: Fri, 1 Dec 2017 14:03:31 +0200 Message-ID: Subject: Re: [PATCH v3] scripts/package: snap-pkg target To: Paolo Pisati Cc: Masahiro Yamada , Jim Davis , Michal Marek , Behan Webster , Matthias Kaehlcke , =?UTF-8?Q?Vin=C3=ADcius_Tinti?= , linux-kbuild , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 650 Lines: 20 On 29 November 2017 at 19:05, Paolo Pisati wrote: > On Wed, Nov 29, 2017 at 8:33 AM, Masahiro Yamada > wrote: >> >> Worked for me too, >> after updating snapcraft. >> >> >> Is it really impossible to check the snapcraft version? >> What is the minimum version? 2.35 ? > > The minimum version is 2.35+ - what is about to become 2.36 anytime soon now. Since you are already patching snapcraft for this, why not embed the whole support in snapcraft? Eg something like snapcraft --kernel /path/to/kernel The key advantage you'll get is being able to support old kernel versions too. Riku