Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752563AbdLAMK7 (ORCPT ); Fri, 1 Dec 2017 07:10:59 -0500 Received: from fllnx210.ext.ti.com ([198.47.19.17]:15610 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752430AbdLAMK6 (ORCPT ); Fri, 1 Dec 2017 07:10:58 -0500 Subject: Re: [PATCHv1 03/14] drm/omap: plane: update fifo size on ovl setup To: Sebastian Reichel , Sebastian Reichel , Tony Lindgren CC: Laurent Pinchart , , , References: <20170724173311.27170-1-sebastian.reichel@collabora.co.uk> <20170724173311.27170-4-sebastian.reichel@collabora.co.uk> From: Tomi Valkeinen Message-ID: <34c2588e-7d7e-219f-fd34-9a441d46e0cc@ti.com> Date: Fri, 1 Dec 2017 14:10:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20170724173311.27170-4-sebastian.reichel@collabora.co.uk> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2230 Lines: 61 On 24/07/17 20:33, Sebastian Reichel wrote: > This is a workaround for a hardware bug occuring on OMAP3 > with manually updated panels. Details about the HW bug are > unknown to me, but without this fix the panel refresh does > not work at all on Nokia N950. > > Signed-off-by: Sebastian Reichel > --- > drivers/gpu/drm/omapdrm/dss/dispc.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/drivers/gpu/drm/omapdrm/dss/dispc.c b/drivers/gpu/drm/omapdrm/dss/dispc.c > index fd7504b37e3b..b6dca5ee34d4 100644 > --- a/drivers/gpu/drm/omapdrm/dss/dispc.c > +++ b/drivers/gpu/drm/omapdrm/dss/dispc.c > @@ -1398,6 +1398,18 @@ void dispc_ovl_compute_fifo_thresholds(enum omap_plane_id plane, > } > } > > +void dispc_ovl_set_manual_fifo_threshold(enum omap_plane_id plane) > +{ > + u32 fifo_low, fifo_high; > + bool use_fifo_merge = false; > + bool use_manual_update = true; > + > + dispc_ovl_compute_fifo_thresholds(plane, &fifo_low, &fifo_high, > + use_fifo_merge, use_manual_update); > + > + dispc_ovl_set_fifo_threshold(plane, fifo_low, fifo_high); > +} > + > static void dispc_ovl_set_mflag(enum omap_plane_id plane, bool enable) > { > int bit; > @@ -2566,6 +2578,10 @@ static int dispc_ovl_setup(enum omap_plane_id plane, > oi->zorder, oi->pre_mult_alpha, oi->global_alpha, > oi->rotation_type, replication, vm, mem_to_mem); > > + /* manual mode needs other fifo thresholds */ > + if (mgr_fld_read(channel, DISPC_MGR_FLD_STALLMODE)) > + dispc_ovl_set_manual_fifo_threshold(plane); > + > return r; > } We don't have the stallmode for all channels. And on OMAP2 it's for RFBI, and I don't know if that needs different thresholds or not. Also, I'm not sure if OMAP4-5 DSI needs this. And I think it's good to mention the unknown bug in the comment too. And yes, it's unknown to me too, I never figured it out. These thresholds just seemed to work, while the default did not. So I think we need to check that the platform is OMAP3 and channel is LCD. We can later extend that to cover OMAP4-5 if needed. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki