Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752561AbdLAM26 (ORCPT ); Fri, 1 Dec 2017 07:28:58 -0500 Received: from fllnx210.ext.ti.com ([198.47.19.17]:16127 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752492AbdLAM24 (ORCPT ); Fri, 1 Dec 2017 07:28:56 -0500 Subject: Re: [PATCHv1 08/14] drm/omap: panel-dsi-cm: fix driver To: Sebastian Reichel , Sebastian Reichel , Tony Lindgren CC: Laurent Pinchart , , , References: <20170724173311.27170-1-sebastian.reichel@collabora.co.uk> <20170724173311.27170-9-sebastian.reichel@collabora.co.uk> From: Tomi Valkeinen Message-ID: <1290ca0f-4fc8-89ca-f943-8420f2bdeaff@ti.com> Date: Fri, 1 Dec 2017 14:28:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20170724173311.27170-9-sebastian.reichel@collabora.co.uk> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 766 Lines: 21 Hi, On 24/07/17 20:33, Sebastian Reichel wrote: > From: Tony Lindgren > > This adds support for get_timings() and check_timings() > to get the driver working and properly initializes the > timing information from DT. I don't know if it matters much, but the timings added to dts in the following patches are mostly not used, and do not make sense for DSI command mode panel. Only hactive and vactive are used. But if full video timings are present in the dts, then I think it would be good to have the timings correct, so that also pixel clock is defined, and the timings would produce 60Hz refresh rate. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki