Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751407AbdLAQdg (ORCPT ); Fri, 1 Dec 2017 11:33:36 -0500 Received: from mail-vk0-f65.google.com ([209.85.213.65]:33508 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988AbdLAQde (ORCPT ); Fri, 1 Dec 2017 11:33:34 -0500 X-Google-Smtp-Source: AGs4zMaiwkE9mtZm/GO1XPvJSkE+4lFgTa0i+mMcVbMCJUszxPmTPDlb9HU7h36ZqSenFOa2YnTkRw3ntdd2v5tHmd0= MIME-Version: 1.0 In-Reply-To: <20171201153444.GA17867@kroah.com> References: <20171129045927.GA6217@eros> <20171129210848.GF6217@eros> <20171130163235.GA27849@kroah.com> <20171130171036.GB31817@kroah.com> <20171201094846.GE9353@kroah.com> <20171201153444.GA17867@kroah.com> From: Kees Cook Date: Fri, 1 Dec 2017 08:33:32 -0800 X-Google-Sender-Auth: 1cVpsVn-aXYKoqSc7E_ska_udzg Message-ID: Subject: Re: [GIT PULL] hash addresses printed with %p To: Greg Kroah-Hartman Cc: Ard Biesheuvel , Linus Torvalds , "Tobin C. Harding" , Matt Fleming , LKML , "linux-efi@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 473 Lines: 15 On Fri, Dec 1, 2017 at 7:34 AM, Greg Kroah-Hartman wrote: > And isn't there a specific %p modifier you should use for a kernel > pointer. I've lost the thread here for what should, or should not, be > done for kernel pointers these days based on the long email discussion. Current implementation to bypass the hashing is %px. (Though perhaps all %px usage should include a comment with a justification?) -Kees -- Kees Cook Pixel Security