Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752228AbdLATXq (ORCPT ); Fri, 1 Dec 2017 14:23:46 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:45828 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752067AbdLATXn (ORCPT ); Fri, 1 Dec 2017 14:23:43 -0500 Subject: Re: [PATCH net-next 3/3] xfrm: Add ESN support for IPSec HW offload To: Steffen Klassert , yossefe@mellanox.com Cc: "David S. Miller" , Herbert Xu , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, borisp@mellanox.com, kliteyn@mellanox.com, yossiku@mellanox.com References: <1511862571-3494-1-git-send-email-yossefe@mellanox.com> <1511862571-3494-3-git-send-email-yossefe@mellanox.com> <20171201062321.dt3jbrfs4svwpgqx@gauss3.secunet.de> From: Shannon Nelson Organization: Oracle Corporation Message-ID: Date: Fri, 1 Dec 2017 11:23:18 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171201062321.dt3jbrfs4svwpgqx@gauss3.secunet.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1264 Lines: 37 On 11/30/2017 10:23 PM, Steffen Klassert wrote: > On Tue, Nov 28, 2017 at 11:49:30AM +0200, yossefe@mellanox.com wrote: >> From: Yossef Efraim >> >> This patch adds ESN support to IPsec device offload. >> Adding new xfrm device operation to synchronize device ESN. >> >> Signed-off-by: Yossef Efraim >> --- >> include/linux/netdevice.h | 1 + >> include/net/xfrm.h | 12 ++++++++++++ >> net/xfrm/xfrm_device.c | 4 ++-- >> net/xfrm/xfrm_replay.c | 2 ++ >> 4 files changed, 17 insertions(+), 2 deletions(-) >> >> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h >> index 7de7656..d4e9198 100644 >> --- a/include/linux/netdevice.h >> +++ b/include/linux/netdevice.h >> @@ -825,6 +825,7 @@ struct xfrmdev_ops { >> void (*xdo_dev_state_free) (struct xfrm_state *x); >> bool (*xdo_dev_offload_ok) (struct sk_buff *skb, >> struct xfrm_state *x); >> + void (*xdo_dev_state_advance_esn) (struct xfrm_state *x); > > We now have a documentation for the xfrm offloadin API in the > ipsec-next tree. Please document the new device operation > there and resubmit. Please be sure to specify what the offloading driver is expected to do with this. sln > > Thanks! >