Subject: Re: [PATCH v2 3/4] Add support for AMD Core Perf Extension in guest
To: Borislav Petkov <bp@suse.de>, Paolo Bonzini <pbonzini@redhat.com>,
        Radim Krcmar <rkrcmar@redhat.com>
Cc: kvm@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>, Len Brown <len.brown@intel.com>,
        Kyle Huey <me@kylehuey.com>, Kan Liang <Kan.liang@intel.com>,
        Grzegorz Andrejczuk <grzegorz.andrejczuk@intel.com>,
        Tom Lendacky <thomas.lendacky@amd.com>,
        Tony Luck <tony.luck@intel.com>
References: <cover.1509985085.git.Janakarajan.Natarajan@amd.com>
 <5113a9d6e76d2c6050c1fba4007068340321521c.1509985085.git.Janakarajan.Natarajan@amd.com>
 <20171109183425.rhqc5wrltznt5tcf@pd.tnic>
 <07f23e5e-2747-b0bc-1b93-f83f3982649a@amd.com>
 <20171115190755.5n2zskcr2d4bmewp@pd.tnic>
 <c94fbc32-307f-01b9-564d-cfc68c94648a@amd.com>
 <20171116172520.4lgdvpcdxuxenxc7@pd.tnic>
 <2c785f9f-faac-58d5-2efd-3fce80d24c18@amd.com>
 <20171117114445.iv2s7sm2mjqusztx@pd.tnic>
From: "Natarajan, Janakarajan" <Janakarajan.Natarajan@amd.com>
Message-ID: <8ff957e3-67b7-3986-05ef-3e42bd7143f6@amd.com>
Date: Fri, 1 Dec 2017 13:30:15 -0600
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171117114445.iv2s7sm2mjqusztx@pd.tnic>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Dec 2017 19:30:18.6564 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: ab9bd10c-b036-4ab1-045c-08d538f1f5f2
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1667
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1071
Lines: 34

On 11/17/2017 5:44 AM, Borislav Petkov wrote:
> On Thu, Nov 16, 2017 at 12:00:11PM -0600, Natarajan, Janakarajan wrote:
>> Ah my apologies. So when the pmu is initialized the cpuid entries
>> aren't available then.
> So let's see:
>
> ... kvm_arch_vcpu_create() ->
> svm_create_vcpu() ->
> kvm_vcpu_init() ->
> kvm_arch_vcpu_init() ->
>
> <--- HERE
>
> kvm_pmu_init()
>
> But at HERE in kvm_arch_vcpu_init() right before kvm_pmu_init() we do already query
> cpuid:
>
> 	vcpu->arch.maxphyaddr = cpuid_query_maxphyaddr(vcpu);
>
> so it's not like we don't know about cpuid leafs at that point. Which
> would mean that the code can be made to set the CPU family earlier,
> before kvm_pmu_init() runs so that you have the proper CPU family and
> thus have this thing properly designed.
>
> Maybe Paolo and Radim have a better suggestion here...

Paolo, Radim any suggestions about this. I feel that the number of 
counters initialized can be 6
and the subsequent code (kvm_pmu_refresh()) takes care of the number of 
counters to be used (4 or 6)
based on the vcpu family.

>