DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DF54221905
Date: Fri, 1 Dec 2017 14:48:50 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Jason Gunthorpe <jgg@mellanox.com>
Cc: Ingo Molnar <mingo@redhat.com>,
        Jesper Dangaard Brouer <brouer@redhat.com>,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] bpf: Fix compile warnings when !CONFIG_BPF_SYSCALL
Message-ID: <20171201144850.675ed351@gandalf.local.home>
In-Reply-To: <20171201190605.GA21174@ziepe.ca>
References: <20171201190605.GA21174@ziepe.ca>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1276
Lines: 42

On Fri, 1 Dec 2017 12:06:05 -0700
Jason Gunthorpe <jgg@mellanox.com> wrote:

> Such as:
> 
> In file included from ./include/trace/events/xdp.h:10:0,
>                  from ./include/linux/bpf_trace.h:6,
>                  from drivers/net/ethernet/intel/i40e/i40e_txrx.c:29:
> ./include/trace/events/xdp.h:94:17: warning: ‘struct bpf_map’ declared inside parameter list
>     const struct bpf_map *map, u32 map_index),
>                  ^
> 
> By adding a forward declaration for struct bpf_map. In the
> CONFIG_BPF_SYSCALL case the declaration comes in via
> trace/events/bpf.h

This was already fixed:

 http://lkml.kernel.org/r/1512006089-180279-1-git-send-email-xiexiuqi@huawei.com

-- Steve

> 
> Fixes: 59a308967589 ("xdp: separate xdp_redirect tracepoint in map case")
> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
> ---
>  include/trace/events/xdp.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/trace/events/xdp.h b/include/trace/events/xdp.h
> index 4cd0f05d01134d..36b2a9043189be 100644
> --- a/include/trace/events/xdp.h
> +++ b/include/trace/events/xdp.h
> @@ -9,6 +9,8 @@
>  #include <linux/filter.h>
>  #include <linux/tracepoint.h>
>  
> +struct bpf_map;
> +
>  #define __XDP_ACT_MAP(FN)	\
>  	FN(ABORTED)		\
>  	FN(DROP)		\