Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752189AbdLATyj (ORCPT ); Fri, 1 Dec 2017 14:54:39 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:37439 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751555AbdLATyd (ORCPT ); Fri, 1 Dec 2017 14:54:33 -0500 X-Google-Smtp-Source: AGs4zMaPErmeWlYzu0xvgJGM0BRrlDqHGRKCopnmQIQaQ5cE72i5IZ+lj4GzH3J5r3Z1twfRQvzI3ncCVq5BKae2q8U= MIME-Version: 1.0 In-Reply-To: <1512135743-16529-3-git-send-email-thierry.escande@collabora.com> References: <1512135743-16529-1-git-send-email-thierry.escande@collabora.com> <1512135743-16529-3-git-send-email-thierry.escande@collabora.com> From: Gwendal Grignou Date: Fri, 1 Dec 2017 11:54:11 -0800 X-Google-Sender-Auth: A4mZHFo2UTbkjFYMVsuBTMfEaJQ Message-ID: Subject: Re: [PATCH v5 2/3] platform/chrome: cros_ec_lpc: Add support for Google Glimmer To: Thierry Escande Cc: Benson Leung , Lee Jones , Jonathan Cameron , Enric Balletbo i Serra , Gwendal Grignou , Linux Kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1541 Lines: 45 This is not required. Looking with dmidecode, Glimmer reports: ... BIOS Information Vendor: coreboot Version: Google_Glimmer.5216.198.19 ... Therefore, the first entry of cros_ec_lpc_dmi_table will match. Gwendal. On Fri, Dec 1, 2017 at 5:42 AM, Thierry Escande wrote: > This patch adds device information to the DMI table of the cros_ec_lpc > driver for Google Glimmer devices. Since Google BIOS does not enumerate > devices in the LPC bus, the cros_ec_lpc driver checks for system > compatibility and registers the cros_ec device itself. > > Signed-off-by: Thierry Escande > --- > drivers/platform/chrome/cros_ec_lpc.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c > index 0b26a09..4a2fc55 100644 > --- a/drivers/platform/chrome/cros_ec_lpc.c > +++ b/drivers/platform/chrome/cros_ec_lpc.c > @@ -365,6 +365,13 @@ static const struct dmi_system_id cros_ec_lpc_dmi_table[] __initconst = { > DMI_MATCH(DMI_PRODUCT_NAME, "Peppy"), > }, > }, > + { > + /* x86-glimmer, the Lenovo Thinkpad Yoga 11e. */ > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"), > + DMI_MATCH(DMI_PRODUCT_NAME, "Glimmer"), > + }, > + }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(dmi, cros_ec_lpc_dmi_table); > -- > 2.7.4 >