Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751491AbdLAT6n (ORCPT ); Fri, 1 Dec 2017 14:58:43 -0500 Received: from mga03.intel.com ([134.134.136.65]:54434 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751031AbdLAT6l (ORCPT ); Fri, 1 Dec 2017 14:58:41 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,346,1508828400"; d="scan'208";a="155154612" From: "Nikolova, Tatyana E" To: Geert Uytterhoeven , Roland Dreier , Jason Gunthorpe , Doug Ledford CC: Arnd Bergmann , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2] RDMA/iwpm: Fix uninitialized error code in iwpm_send_mapinfo() Thread-Topic: [PATCH v2] RDMA/iwpm: Fix uninitialized error code in iwpm_send_mapinfo() Thread-Index: AQHTaP6RraUyyf6XwUSvH12MrM/nB6Mu6ULg Date: Fri, 1 Dec 2017 19:58:39 +0000 Message-ID: <13AA599688F47243B14FCFCCC2C803BB3C65ABA3@fmsmsx104.amr.corp.intel.com> References: <1511945253-29296-1-git-send-email-geert@linux-m68k.org> In-Reply-To: <1511945253-29296-1-git-send-email-geert@linux-m68k.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDg2Mjk5MzgtM2ZmMC00YTc0LWJlYTktYzk3YmM4OTc5ZTZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJRM1B5V0Mxa25kT0grSkVKeGJlNnBDMXRGQlFkOUVaNXFycEU0TldSQmRyRmlzZXJQcXJqeEZMUmo3eE84cDB0In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.1.200.106] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vB1Jwl15019244 Content-Length: 1922 Lines: 56 > -----Original Message----- > From: Geert Uytterhoeven [mailto:geert@linux-m68k.org] > Sent: Wednesday, November 29, 2017 2:48 AM > To: Nikolova, Tatyana E ; Roland Dreier > ; Jason Gunthorpe ; Doug > Ledford > Cc: Arnd Bergmann ; linux-rdma@vger.kernel.org; linux- > kernel@vger.kernel.org; Geert Uytterhoeven > Subject: [PATCH v2] RDMA/iwpm: Fix uninitialized error code in > iwpm_send_mapinfo() > > With gcc-4.1.2: > > drivers/infiniband/core/iwpm_util.c: In function ‘iwpm_send_mapinfo’: > drivers/infiniband/core/iwpm_util.c:647: warning: ‘ret’ may be used > uninitialized in this function > > Indeed, if nl_client is not found in any of the scanned has buckets, ret will be > used uninitialized. > > Preinitialize ret to -EINVAL to fix this. > > Fixes: 30dc5e63d6a5ad24 ("RDMA/core: Add support for iWARP Port Mapper > user space service") > Signed-off-by: Geert Uytterhoeven > --- > v2: > - Use -EINVAL instead of zero, > - Move the preinitialization to just before the loop, to catach future > early offenders, > - Drop RFC state. > --- > drivers/infiniband/core/iwpm_util.c | 1 + > 1 file changed, 1 insertion(+) > Thanks. Reviewed-by: Tatyana Nikolova > diff --git a/drivers/infiniband/core/iwpm_util.c > b/drivers/infiniband/core/iwpm_util.c > index 3c4faadb8cddd7fd..81528f64061a49df 100644 > --- a/drivers/infiniband/core/iwpm_util.c > +++ b/drivers/infiniband/core/iwpm_util.c > @@ -654,6 +654,7 @@ int iwpm_send_mapinfo(u8 nl_client, int iwpm_pid) > } > skb_num++; > spin_lock_irqsave(&iwpm_mapinfo_lock, flags); > + ret = -EINVAL; > for (i = 0; i < IWPM_MAPINFO_HASH_SIZE; i++) { > hlist_for_each_entry(map_info, &iwpm_hash_bucket[i], > hlist_node) { > -- > 2.7.4