Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752036AbdLBAAW (ORCPT ); Fri, 1 Dec 2017 19:00:22 -0500 Received: from mail-ot0-f195.google.com ([74.125.82.195]:40558 "EHLO mail-ot0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751699AbdLBAAU (ORCPT ); Fri, 1 Dec 2017 19:00:20 -0500 X-Google-Smtp-Source: AGs4zMa7T0lhbaF+WeS22S//EMQtVsMcImuSpNJdd9OuiKpigy42990Np/WlzcZ03QEPW5dgJAKXeA== Subject: Re: [PATCH net-next] net: dsa: Allow compiling out legacy support To: Vivien Didelot , netdev@vger.kernel.org Cc: Andrew Lunn , "David S. Miller" , open list References: <20171130235857.12809-1-f.fainelli@gmail.com> <87bmjizd61.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> From: Florian Fainelli Message-ID: <86660f52-e711-beb4-33d2-0ea38db5a4fc@gmail.com> Date: Fri, 1 Dec 2017 16:00:00 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <87bmjizd61.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2423 Lines: 74 On 12/01/2017 07:21 AM, Vivien Didelot wrote: > Hi Florian, > > Florian Fainelli writes: > >> +#if IS_ENABLED(CONFIG_NET_DSA_LEGACY) >> /* Legacy driver registration */ >> void register_switch_driver(struct dsa_switch_driver *type); >> void unregister_switch_driver(struct dsa_switch_driver *type); >> struct mii_bus *dsa_host_dev_to_mii_bus(struct device *dev); >> >> +#else >> +static inline void register_switch_driver(struct dsa_switch_driver *type) { } >> +static inline void unregister_switch_driver(struct dsa_switch_driver *type) { } >> +static inline struct mii_bus *dsa_host_dev_to_mii_bus(struct device *dev) >> +{ >> + return NULL; >> +} >> +#endif > > The .probe dsa_switch_ops is part of the legacy code, we may want to > wrap it in a CONFIG_NET_DSA_LEGACY check as well. Fixed, also made 88e6060 dependent on CONFIG_NET_DSA_LEGACY as a result. > >> struct net_device *dsa_dev_to_net_device(struct device *dev); >> >> /* Keep inline for faster access in hot path */ >> diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig >> index 03c3bdf25468..b6ec8e9069e4 100644 >> --- a/net/dsa/Kconfig >> +++ b/net/dsa/Kconfig >> @@ -16,6 +16,14 @@ config NET_DSA >> >> if NET_DSA >> >> +config NET_DSA_LEGACY > > We need to have it enabled by default, otherwise we'll miss errors when > touching the code shared by both legacy and new bindings. Fixed. > >> + bool "Support for older platform device and Device Tree registration" >> + ---help--- >> + Say Y if you want to enable support for the older platform device and >> + deprectaed Device Tree binding registration. > > deprecated* > >> + >> + This feature is scheduled for removal in 4.17. >> + >> /* legacy.c */ >> +#if IS_ENABLED(CONFIG_NET_DSA_LEGACY) >> int dsa_legacy_register(void); >> void dsa_legacy_unregister(void); >> int dsa_legacy_fdb_add(struct ndmsg *ndm, struct nlattr *tb[], >> @@ -106,6 +107,28 @@ int dsa_legacy_fdb_add(struct ndmsg *ndm, struct nlattr *tb[], >> int dsa_legacy_fdb_del(struct ndmsg *ndm, struct nlattr *tb[], >> struct net_device *dev, >> const unsigned char *addr, u16 vid); > > the dsa_legacy_fdb_{add,del} routines are "legacy" in terms of FDB > handling, not in terms of DSA bindings, we must keep them. Oh, right. This should probably be moved somewhere else then, right? The whole idea was to compile out net/dsa/legacy.c -- Florian