Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751680AbdLBKeV (ORCPT ); Sat, 2 Dec 2017 05:34:21 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:54269 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbdLBKeT (ORCPT ); Sat, 2 Dec 2017 05:34:19 -0500 Date: Sat, 2 Dec 2017 11:34:12 +0100 (CET) From: Thomas Gleixner To: Andy Lutomirski cc: X86 ML , Borislav Petkov , "linux-kernel@vger.kernel.org" , Brian Gerst , Dave Hansen , Linus Torvalds , Josh Poimboeuf Subject: Re: [PATCH 1/2] Undo the split of setup_cpu_entry_area In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 514 Lines: 15 On Fri, 1 Dec 2017, Andy Lutomirski wrote: > This is obviously a hack. Either the patch should be adjusted back to > the version I sent or trap_init should forcibly initialize all PMDs > by something like __set_fixmap(..., __mkpte(0)); or however it's spelled. I split it because the whole thing crashed when I kept the loop you had because it tried to allocate stuff. Had no time to figure out why, so I went the lazy way of making it "work". Simplifying the whole mess was on my list anyway. Thanks, tglx