Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751747AbdLBMj0 (ORCPT ); Sat, 2 Dec 2017 07:39:26 -0500 Received: from mx2.suse.de ([195.135.220.15]:59560 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751649AbdLBMjZ (ORCPT ); Sat, 2 Dec 2017 07:39:25 -0500 Date: Sat, 2 Dec 2017 04:35:26 -0800 From: Davidlohr Bueso To: Vito Caputo Cc: linux-kernel , linux-doc@vger.kernel.org Subject: Re: [PATCH] rbtree.txt: fix typo in cached rbtree section Message-ID: <20171202123526.olzjs7ukmt55i4lp@linux-n805> References: <20171201235223.GX692@shells.gnugeneration.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20171201235223.GX692@shells.gnugeneration.com> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1360 Lines: 36 I'm happy to ack your patch but you have to send it correctly. You are missing a changelog (although it ought to be small due to the trivial change) as well as you SoB tag. Please consult Documentation/process/submitting-patches.rst. You also need to Cc akpm as he routes such areas to Linus. Thanks, Davidlohr On Fri, 01 Dec 2017, Vito Caputo wrote: >--- > Documentation/rbtree.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/Documentation/rbtree.txt b/Documentation/rbtree.txt >index c42a21b99046..3a4c23bc90b2 100644 >--- a/Documentation/rbtree.txt >+++ b/Documentation/rbtree.txt >@@ -197,9 +197,9 @@ Cached rbtrees > -------------- > > Computing the leftmost (smallest) node is quite a common task for binary >-search trees, such as for traversals or users relying on a the particular >-order for their own logic. To this end, users can use 'struct rb_root_cached' >-to optimize O(logN) rb_first() calls to a simple pointer fetch avoiding >+search trees, such as for traversals or users relying on a particular order >+for their own logic. To this end, users can use 'struct rb_root_cached' to >+optimize O(logN) rb_first() calls to a simple pointer fetch avoiding > potentially expensive tree iterations. This is done at negligible runtime > overhead for maintanence; albeit larger memory footprint. > >-- >2.11.0 >