Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751995AbdLBPpE (ORCPT ); Sat, 2 Dec 2017 10:45:04 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:59522 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751779AbdLBPpD (ORCPT ); Sat, 2 Dec 2017 10:45:03 -0500 Date: Sat, 2 Dec 2017 14:58:43 +0000 From: Greg KH To: Marcus Wolf Cc: dan.carpenter@oracle.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: pi433: Bugfix for shift operation in rf69_get_modulation() Message-ID: <20171202145843.GB1242@kroah.com> References: <1512210741-475-1-git-send-email-linux@wolf-entwicklungen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512210741-475-1-git-send-email-linux@wolf-entwicklungen.de> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 589 Lines: 20 On Sat, Dec 02, 2017 at 12:32:20PM +0200, Marcus Wolf wrote: > Defines used in cases contain already shifted bits, so currentValue must not be shifted. Please properly wrap your changelog text. And you need a blank line before your signed-off-by line. > signed_of_by: Marcus Wolf "Signed-off-by:" Did you run scripts/checkpatch.pl on your patch? You sent 4 patches just now, which order should I apply them in? I have no idea, so please fix them up and resend them as a numbered patch series so that I have a chance to get it right. thanks, greg k-h