Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752061AbdLBPpI (ORCPT ); Sat, 2 Dec 2017 10:45:08 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:59532 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751779AbdLBPpG (ORCPT ); Sat, 2 Dec 2017 10:45:06 -0500 Date: Sat, 2 Dec 2017 14:59:04 +0000 From: Greg KH To: Marcus Wolf Cc: dan.carpenter@oracle.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: pi433: Bugfix for shift operation in rf69_get_modulation() Message-ID: <20171202145904.GC1242@kroah.com> References: <1512211914-18844-1-git-send-email-linux@wolf-entwicklungen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1512211914-18844-1-git-send-email-linux@wolf-entwicklungen.de> User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 293 Lines: 11 On Sat, Dec 02, 2017 at 12:51:54PM +0200, Marcus Wolf wrote: > Defines used in cases contain already shifted bits, so currentValue must not be shifted. > Signed-off-by: Marcus Wolf Odd extra ' ' in your subject :( And again, linewrap please. thanks, greg k-h