Date: Sat, 2 Dec 2017 16:09:28 +0000
From: Greg KH <gregkh@linuxfoundation.org>
To: Marcus Wolf <marcus.wolf@smarthome-wolf.de>
Cc: Marcus Wolf <linux@wolf-entwicklungen.de>, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org, dan.carpenter@oracle.com
Subject: Re: [PATCH] staging: pi433: Removed some obsolete or duplicated
 defines; moved two defines to better locations
Message-ID: <20171202160928.GA7067@kroah.com>
References: <1512227648-16008-1-git-send-email-linux@wolf-entwicklungen.de>
 <20171202155549.GA5960@kroah.com>
 <30f27e3f-bd83-f44b-f0b1-f3c97fa2373c@smarthome-wolf.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <30f27e3f-bd83-f44b-f0b1-f3c97fa2373c@smarthome-wolf.de>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 950
Lines: 31


A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Sat, Dec 02, 2017 at 06:00:28PM +0200, Marcus Wolf wrote:
> Hi Greg,
> 
> for me the action was "clean up the defines in rf69.c". So for me it was
> fine, that two defines were moved and several other deleted at the same.
> 
> Is it ok for you, or should I split the patch belated?

Please split it up, and make a patch series.  Don't dribble patches out
over many hours as that just ensures that I will apply them in the wrong
order :(

Take the time, make a patch series, test that they pass the scripts that
we have, and then send them all out at once.

thanks,

greg k-h