Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752129AbdLBQtb (ORCPT ); Sat, 2 Dec 2017 11:49:31 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:43142 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751783AbdLBQt3 (ORCPT ); Sat, 2 Dec 2017 11:49:29 -0500 X-Google-Smtp-Source: AGs4zMZuY10STzcuaSXCIqsOUpR5027Olt5WwhKmncwGWDk5diJojjuvO1CYls71Ldx66OhdLP3wGQ== Subject: Re: [PATCH] gpio: ftgpio010: Fix platform_get_irq's error checking To: Linus Walleij References: Cc: "linux-kernel@vger.kernel.org" , linux-gpio@vger.kernel.org From: arvindY Message-ID: <5A22D995.9010802@gmail.com> Date: Sat, 2 Dec 2017 22:19:25 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 985 Lines: 37 Hi Linus, On Saturday 02 December 2017 09:00 PM, Linus Walleij wrote: > Hi Arvind, > > thanks for the patch! > > On Thu, Nov 30, 2017 at 3:12 PM, Arvind Yadav wrote: > >> The platform_get_irq() function returns negative if an error occurs. >> zero or positive number on success. platform_get_irq() error checking >> for zero is not correct. >> >> Signed-off-by: Arvind Yadav > (...) >> irq = platform_get_irq(pdev, 0); >> - if (!irq) >> - return -EINVAL; >> + if (irq < 0) >> + return irq; > This is wrong. > For an in-depth explanation why irq 0 in not valid, see: > https://lwn.net/Articles/470820/ Thank you for sharing this Articles. It's really helpful. > > It should be: > > if (irq <= 0) > return irq ? irq : -EINVAL; > > Please update and resubmit. If you have more patches like this, > correct them too. I will resubmit patch. > Yours, > Linus Walleij Thanks, arvind