Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752499AbdLBSHC convert rfc822-to-8bit (ORCPT ); Sat, 2 Dec 2017 13:07:02 -0500 Received: from lhrrgout.huawei.com ([194.213.3.17]:64005 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751197AbdLBSHA (ORCPT ); Sat, 2 Dec 2017 13:07:00 -0500 From: Salil Mehta To: Andrew Lunn CC: "davem@davemloft.net" , "Zhuangyuzeng (Yisen)" , "lipeng (Y)" , "mehta.salil.lnk@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , Linuxarm Subject: RE: [PATCH net-next] net: hns3: Refactors "reset" handling code in HCLGE layer of HNS3 driver Thread-Topic: [PATCH net-next] net: hns3: Refactors "reset" handling code in HCLGE layer of HNS3 driver Thread-Index: AQHTalXRQN7D2AA5LEu4a/FNTruxjKMub4WAgAHsPlA= Date: Sat, 2 Dec 2017 18:06:48 +0000 Message-ID: References: <20171201033744.19104-1-salil.mehta@huawei.com> <20171201134415.GD22599@lunn.ch> In-Reply-To: <20171201134415.GD22599@lunn.ch> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.226.117] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2236 Lines: 51 Hi Andrew, > -----Original Message----- > From: Andrew Lunn [mailto:andrew@lunn.ch] > Sent: Friday, December 01, 2017 1:44 PM > To: Salil Mehta > Cc: davem@davemloft.net; Zhuangyuzeng (Yisen) > ; lipeng (Y) ; > mehta.salil.lnk@gmail.com; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-rdma@vger.kernel.org; Linuxarm > > Subject: Re: [PATCH net-next] net: hns3: Refactors "reset" handling > code in HCLGE layer of HNS3 driver > > On Fri, Dec 01, 2017 at 03:37:44AM +0000, Salil Mehta wrote: > > This patch refactors the code of the reset feature in HCLGE layer > > of HNS3 PF driver. Prime motivation to do this change is: > > 1. To reduce the time for which common miscellaneous Vector 0 > > interrupt is disabled because of the reset. > > 2. Simplification of reset request submission and pending reset > > logic. > > 3. Simplification of the common miscellaneous interrupt handler > > routine(for Vector 0) used to handle reset and other sources > > of Vector 0 interrupt. > > > > To achieve above below few things have been done: > > 1. Interrupt is disabled while common miscellaneous interrupt > > handler is entered and re-enabled before it is exit. This > > reduces the interrupt handling latency as compared to older > > interrupt handling scheme where interrupt was being disabled > > in interrupt handler context and re-enabled in task context > > some time later. > > 2. Introduces new reset service task for honoring software reset > > requests like from network stack related to timeout and serving > > the pending reset request(to reset the driver and associated > > clients). > > 3. Made Miscellaneous interrupt handler more generic to handle > > all sources including reset interrupt source. > > Hi Salil > > This is a rather large patch. Can you break it up? It seems like you > should be able to break it up into at least three parts, maybe more. > > You are aiming to have small patches which are obviously correct. It > is much easier to review than one big patch which is not obvious at > all. Ok. No issues. I will try to fix this in V2 version. > > Andrew