Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752289AbdLBUZy (ORCPT ); Sat, 2 Dec 2017 15:25:54 -0500 Received: from mail-it0-f48.google.com ([209.85.214.48]:47048 "EHLO mail-it0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752166AbdLBUZw (ORCPT ); Sat, 2 Dec 2017 15:25:52 -0500 X-Google-Smtp-Source: AGs4zMb6TpC4h22XJ94ah6QXFbuue/bnimBmjbMJK+tWVYSjrEf2reuquAWmO8jUkHfSKM/cx9lLvXgsWYYcbpJZoLc= MIME-Version: 1.0 In-Reply-To: <5abcacf8ee7ecb1e084f93c82cae1768e99fd4e6.1512233762.git.arvind.yadav.cs@gmail.com> References: <5abcacf8ee7ecb1e084f93c82cae1768e99fd4e6.1512233762.git.arvind.yadav.cs@gmail.com> From: Linus Walleij Date: Sat, 2 Dec 2017 21:25:51 +0100 Message-ID: Subject: Re: [PATCH v2] gpio: ftgpio010: Fix platform_get_irq's error checking To: Arvind Yadav Cc: "linux-kernel@vger.kernel.org" , linux-gpio@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 463 Lines: 15 On Sat, Dec 2, 2017 at 6:01 PM, Arvind Yadav wrote: > The platform_get_irq() function returns negative if an error occurs. > zero or positive number on success. platform_get_irq() error checking > for zero is not correct. > > Signed-off-by: Arvind Yadav > --- > changes in v2: > It's should be 'irq <= 0' instead of 'irq < 0'. Yep that's the right patch! Patch applied. Yours, Linus Walleij