Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752136AbdLCJGp (ORCPT ); Sun, 3 Dec 2017 04:06:45 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:49642 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751619AbdLCJGi (ORCPT ); Sun, 3 Dec 2017 04:06:38 -0500 Subject: Re: [RESEND PATCH 2/4] ARM: dts: keystone: Add generic compatible string for I2C EEPROM To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: olof@lixom.net, arm@kernel.org, arnd@arndb.de, devicetree@vger.kernel.org, Santosh Shilimkar , Rob Herring , Mark Rutland , Russell King , linux-arm-kernel@lists.infradead.org References: <20171124162750.18756-1-javierm@redhat.com> <20171124162750.18756-2-javierm@redhat.com> From: "santosh.shilimkar@oracle.com" Organization: Oracle Corporation Message-ID: Date: Sat, 2 Dec 2017 19:57:57 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171124162750.18756-2-javierm@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8733 signatures=668637 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712030059 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 732 Lines: 16 On 11/24/17 8:27 AM, Javier Martinez Canillas wrote: > The at24 driver allows to register I2C EEPROM chips using different vendor > and devices, but the I2C subsystem does not take the vendor into account > when matching using the I2C table since it only has device entries. > > But when matching using an OF table, both the vendor and device has to be > taken into account so the driver defines only a set of compatible strings > using the "atmel" vendor as a generic fallback for compatible I2C devices. > > So add this generic fallback to the device node compatible string to make > the device to match the driver using the OF device ID table. > > Signed-off-by: Javier Martinez Canillas > --- > Applied