From: Trond Myklebust <trondmy@primarydata.com>
To: "linux-kselftest@vger.kernel.org" <linux-kselftest@vger.kernel.org>,
        "elfring@users.sourceforge.net" <elfring@users.sourceforge.net>,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
        "kernel-janitors@vger.kernel.org" <kernel-janitors@vger.kernel.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>
Subject: Re: Difficulties for compilation without extra optimisation
Thread-Topic: Difficulties for compilation without extra optimisation
Thread-Index: AQHTbEFGE6l/WCtPOkq86gSp2T9pvKMxuykA
Date: Sun, 3 Dec 2017 15:17:32 +0000
Message-ID: <1512314250.3673.6.camel@primarydata.com>
References: <7f072f78-eef4-6d87-d233-cee71dac5a32@users.sourceforge.net>
         <a2ac6d05-fdd6-82bb-075e-b7eb81b516fe@users.sourceforge.net>
In-Reply-To: <a2ac6d05-fdd6-82bb-075e-b7eb81b516fe@users.sourceforge.net>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-ID: <AAA8A0E6BD59F24E9A19CEFCF81745B0@namprd11.prod.outlook.com>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: aa7b31fe-0fa0-49cb-a02c-08d53a60f9d7
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Dec 2017 15:17:32.4316
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 03193ed6-8726-4bb3-a832-18ab0d28adb7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB0073
X-MC-Unique: Ek1MImEaN42doopLO7AJog-1
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id vB3FI0TX001362
Content-Length: 1914
Lines: 53

On Sun, 2017-12-03 at 15:15 +0100, SF Markus Elfring wrote:
> Hello,
> 
> I came along some software modules where I suggested source code
> adjustments.
> 
> Example:
> nfs/write: Use common error handling code in
> nfs_lock_and_join_requests()
> 
> https://lkml.org/lkml/2017/11/7/599
> https://patchwork.kernel.org/patch/10047013/
> https://lkml.kernel.org/r/<7f072f78-eef4-6d87-d233-cee71dac5a32@users
> .sourceforge.net>;
> 
> I would like to check corresponding build results then without extra
> optimisation applied by the compiler.
> But I got surprised by error messages for a command like the
> following.
> 
> elfring@Sonne:~/Projekte/Linux/next-patched> my_cc=/usr/bin/gcc-7 &&
> LANG=C make -j4 CC="${my_cc}" HOSTCC="${my_cc}" EXTRA_CFLAGS='-O0'
> allmodconfig fs/nfs/write.o
> …
> In file included from ./include/linux/compiler.h:58:0,
>                  from ./include/uapi/linux/stddef.h:1,
>                  from ./include/linux/stddef.h:4,
>                  from ./include/uapi/linux/posix_types.h:4,
>                  from ./include/uapi/linux/types.h:13,
>                  from ./include/linux/types.h:5,
>                  from fs/nfs/write.c:9:
> ./arch/x86/include/asm/jump_label.h: In function
> ‘trace_nfs_writeback_page_enter’:
> ./include/linux/compiler-gcc.h:275:38: warning: asm operand 0
> probably doesn’t match constraints
>  #define asm_volatile_goto(x...) do { asm goto(x); asm (""); } while
> (0)
> …
> 
> 
> How do you think about to improve this software situation anyhow?

I'm not seeing anything obviously wrong with the NFS use of tracepoints
there, and the warning suggests rather that gcc has an issue with the
inlined assembly code in jump_label.h.

Ccing Peter Zijlstra (who appears to have been the last person to touch
that assembly code) and Steven Rostedt.

-- 
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com