Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752917AbdLDCeB (ORCPT ); Sun, 3 Dec 2017 21:34:01 -0500 Received: from smtprelay0053.hostedemail.com ([216.40.44.53]:36738 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752434AbdLDCeA (ORCPT ); Sun, 3 Dec 2017 21:34:00 -0500 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::::::,RULES_HIT:41:355:379:541:599:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3867:3871:3873:3874:4321:5007:7875:10004:10400:10848:11026:11232:11658:11914:12043:12295:12296:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21451:21611:21627:30029:30054:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: card37_7a093a44e5718 X-Filterd-Recvd-Size: 2810 Message-ID: <1512354837.6321.41.camel@perches.com> Subject: Re: [GIT PULL] hash addresses printed with %p From: Joe Perches To: Dave Young , Matt Fleming , Greg Kroah-Hartman Cc: Ard Biesheuvel , Linus Torvalds , "Tobin C. Harding" , LKML , "linux-efi@vger.kernel.org" Date: Sun, 03 Dec 2017 18:33:57 -0800 In-Reply-To: <20171204020216.GA2436@dhcp-128-65.nay.redhat.com> References: <20171129210848.GF6217@eros> <20171130163235.GA27849@kroah.com> <20171130171036.GB31817@kroah.com> <20171201094846.GE9353@kroah.com> <20171202222244.GA3799@codeblueprint.co.uk> <20171204020216.GA2436@dhcp-128-65.nay.redhat.com> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.26.1-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1237 Lines: 27 On Mon, 2017-12-04 at 10:02 +0800, Dave Young wrote: > I think 0400 is good enough for this issue. > > Greg, would you like to agree add an extra macro like below? [] > -static struct map_attribute map_type_attr = __ATTR_RO(type); > -static struct map_attribute map_phys_addr_attr = __ATTR_RO(phys_addr); > -static struct map_attribute map_virt_addr_attr = __ATTR_RO(virt_addr); > -static struct map_attribute map_num_pages_attr = __ATTR_RO(num_pages); > -static struct map_attribute map_attribute_attr = __ATTR_RO(attribute); > +static struct map_attribute map_type_attr = __ATTR_IRUSR(type); > +static struct map_attribute map_phys_addr_attr = __ATTR_IRUSR(phys_addr); > +static struct map_attribute map_virt_addr_attr = __ATTR_IRUSR(virt_addr); > +static struct map_attribute map_num_pages_attr = __ATTR_IRUSR(num_pages); > +static struct map_attribute map_attribute_attr = __ATTR_IRUSR(attribute); > > /* > * These are default attributes that are added for every memmap entry. > --- linux-x86.orig/include/linux/sysfs.h > +++ linux-x86/include/linux/sysfs.h > @@ -112,6 +112,11 @@ struct attribute_group { > .store = _store, \ > } > > +#define __ATTR_IRUSR(_name) { I'd much prefer __ATTR_0400(_name)