Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753271AbdLDDJ5 (ORCPT ); Sun, 3 Dec 2017 22:09:57 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:38465 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753178AbdLDDJw (ORCPT ); Sun, 3 Dec 2017 22:09:52 -0500 X-Google-Smtp-Source: AGs4zMYnfW1tk2+MqN5FzcFo7uUgBNuICQtsNUy4xfaiAldtRC5My1B+3L5Iw7xRVPCM/4CzAUbPVA== Date: Mon, 4 Dec 2017 11:09:47 +0800 From: Alan Kao To: Philippe Ombredanne Cc: Palmer Dabbelt , Albert Ou , Steven Rostedt , patches@groups.riscv.org, Ingo Molnar , LKML , Alan Kao , Greentime Hu Subject: Re: [PATCH] riscv/ftrace: Add basic support Message-ID: <20171204030946.GB30057@d0b76efcf64c> References: <20171130085335.7949-1-alankao@andestech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1441 Lines: 42 On Thu, Nov 30, 2017 at 12:31:53PM +0100, Philippe Ombredanne wrote: > On Thu, Nov 30, 2017 at 9:53 AM, Alan Kao wrote: > [] > > diff --git a/arch/riscv/include/asm/ftrace.h b/arch/riscv/include/asm/ftrace.h > > new file mode 100644 > > index 000000000000..38beadb07ad5 > > --- /dev/null > > +++ b/arch/riscv/include/asm/ftrace.h > > @@ -0,0 +1,23 @@ > > +/* > > + * Copyright (C) 2017 Andes Technology Corporation > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License version 2 as > > + * published by the Free Software Foundation. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + * > > + * You should have received a copy of the GNU General Public License > > + * along with this program. If not, see . > > + */ > > You may want to use the new SPDX ids here instead? > e.g. > > +// SPDX-License-Identifer: GPL-2.0 > > +// Copyright (C) 2017 Andes Technology Corporation > > Neater and simpler? > See Linus posts on the topic of comment styles too BTW Thanks for the tips. I'll fix this in the next version. Alan Kao > > -- > Cordially > Philippe Ombredanne