Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753322AbdLDEld (ORCPT ); Sun, 3 Dec 2017 23:41:33 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:46018 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753182AbdLDEla (ORCPT ); Sun, 3 Dec 2017 23:41:30 -0500 From: Stewart Smith To: Shilpasri G Bhat , Michael Ellerman , linuxppc-dev@lists.ozlabs.org Cc: linux-kernel@vger.kernel.org, ego@linux.vnet.ibm.com, akshay.adiga@linux.vnet.ibm.com, svaidy@linux.vnet.ibm.com Subject: Re: [PATCH] powerpc/powernv : Add support to enable sensor groups In-Reply-To: <06a771ec-fc79-0515-9166-f2a105eb33d0@linux.vnet.ibm.com> References: <1511760988-10377-1-git-send-email-shilpa.bhat@linux.vnet.ibm.com> <87bmjmzla7.fsf@concordia.ellerman.id.au> <06a771ec-fc79-0515-9166-f2a105eb33d0@linux.vnet.ibm.com> Date: Mon, 04 Dec 2017 15:41:21 +1100 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-GCONF: 00 x-cbid: 17120404-0012-0000-0000-0000156772F2 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00008151; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000243; SDB=6.00955127; UDB=6.00482699; IPR=6.00735164; BA=6.00005727; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00018329; XFM=3.00000015; UTC=2017-12-04 04:41:28 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17120404-0013-0000-0000-000050869AC1 Message-Id: <87609nxfym.fsf@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-04_01:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712040068 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1111 Lines: 27 Shilpasri G Bhat writes: > On 11/28/2017 05:07 PM, Michael Ellerman wrote: >> Shilpasri G Bhat writes: >> >>> Adds support to enable/disable a sensor group. This can be used to >>> select the sensor groups that needs to be copied to main memory by >>> OCC. Sensor groups like power, temperature, current, voltage, >>> frequency, utilization can be enabled/disabled at runtime. >>> >>> Signed-off-by: Shilpasri G Bhat >>> --- >>> The skiboot patch for the opal call is posted below: >>> https://lists.ozlabs.org/pipermail/skiboot/2017-November/009713.html >> >> Can you remind me why we're doing this with a completely bespoke sysfs >> API, rather than using some generic sensors API? >> > > Disabling/Enabling sensor groups is not supported in the current generic sensors > API. And also we dont export all type of sensors in HWMON as not all of them are > environment sensors (like performance). Are there barriers to adding such concepts to the generic sensors API? -- Stewart Smith OPAL Architect, IBM.