Date: Mon, 4 Dec 2017 14:39:25 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Wang Nan <wangnan0@huawei.com>
Cc: linux-kernel@vger.kernel.org, kan.liang@intel.com, acme@kernel.org,
        jolsa@redhat.com, Arnaldo Carvalho de Melo <acme@redhat.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Zhang Mengting <zhangmengting@huawei.com>, kernel-team@lge.com
Subject: Re: [PATCH v2 0/8] perf tools: perf tools: Clarify overwrite and
 backward, bugfix
Message-ID: <20171204053925.GB16360@sejong>
References: <20171203020044.81680-1-wangnan0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20171203020044.81680-1-wangnan0@huawei.com>
User-Agent: Mutt/1.9.1 (2017-09-22)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2927
Lines: 70

On Sun, Dec 03, 2017 at 02:00:36AM +0000, Wang Nan wrote:
> THe final result of this patchset is removing the concept of
> 'forward/backward', merge them into the concept of 'overwrite'.
> 
> Patch 1 to 5 clear arguments lists of many functions, remove the
> 'overwrite'. Because all callers of these functions doesn't need
> the overwrite be set, we can simply remove them from arguments
> lists and adjust code as if a 'false' is given.
> 
> Patch 6 fix a bug that forget to setting readonly for overwrite
> ring buffers.
> 
> Patch 7 is suggested by Liang Kan, prevent dumpping duplicated
> data if there's no so many events between two dumpping commands.
> 
> Patch 8 is 's/backward/overwrite'. After patch 8, the concept of
> 'backward' is removed from most of the code, make it uniform with
> user interface ('--overwrite').
> 
> Cc: Kan Liang <kan.liang@intel.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> Cc: Jiri Olsa <jolsa@kernel.org>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Zhang Mengting <zhangmengting@huawei.com>

I only have a nitpick on the patch 6, but otherwise

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung


> 
> Wang Nan (8):
>   perf tools: Remove 'overwrite' parameter from perf_evlist__mmap
>   perf tools: Remove 'overwrite' parameter from perf_evlist__mmap_ex
>   perf tools: Remove evlist->overwrite
>   perf tools: Remove overwrite from arguments list of perf_mmap__push
>   perf tools: Remove overwrite and check_messup from mmap read
>   perf mmap: Fix perf backward recording
>   perf tool: Don't discard prev in backward mode
>   perf tools: Replace 'backward' to 'overwrite' in evlist, mmap and
>     record
> 
>  tools/perf/arch/x86/tests/perf-time-to-tsc.c |  2 +-
>  tools/perf/builtin-kvm.c                     |  2 +-
>  tools/perf/builtin-record.c                  | 16 +++---
>  tools/perf/builtin-top.c                     |  2 +-
>  tools/perf/builtin-trace.c                   |  2 +-
>  tools/perf/tests/backward-ring-buffer.c      |  6 +--
>  tools/perf/tests/bpf.c                       |  2 +-
>  tools/perf/tests/code-reading.c              |  2 +-
>  tools/perf/tests/keep-tracking.c             |  2 +-
>  tools/perf/tests/mmap-basic.c                |  2 +-
>  tools/perf/tests/openat-syscall-tp-fields.c  |  2 +-
>  tools/perf/tests/perf-record.c               |  2 +-
>  tools/perf/tests/sw-clock.c                  |  2 +-
>  tools/perf/tests/switch-tracking.c           |  2 +-
>  tools/perf/tests/task-exit.c                 |  2 +-
>  tools/perf/util/evlist.c                     | 53 ++++++++++----------
>  tools/perf/util/evlist.h                     |  8 ++-
>  tools/perf/util/mmap.c                       | 73 ++++++++++------------------
>  tools/perf/util/mmap.h                       |  4 +-
>  tools/perf/util/python.c                     |  2 +-
>  20 files changed, 81 insertions(+), 107 deletions(-)
> 
> -- 
> 2.10.1
>