Subject: Re: [PATCH] drm/tilcdc: make tilcdc_mode_hvtotal() static
To: Xiongwei Song <sxwjean@gmail.com>, <tomi.valkeinen@ti.com>,
        <airlied@linux.ie>
CC: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
References: <20171202112422.11176-1-sxwjean@gmail.com>
From: Jyri Sarha <jsarha@ti.com>
Message-ID: <e54e3cd2-4e8b-2576-0d51-c860be6cb414@ti.com>
Date: Mon, 4 Dec 2017 10:10:40 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171202112422.11176-1-sxwjean@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1286
Lines: 38

On 12/02/17 13:24, Xiongwei Song wrote:
> The function tilcdc_mode_hvtotal is local to the source and does not need
> to be in global scope, so make it static.
> 
> drivers/gpu/drm/tilcdc/tilcdc_crtc.c:297:6: warning: no previous prototype for 'tilcdc_mode_hvtotal' [-Wmissing-prototypes]
>  uint tilcdc_mode_hvtotal(const struct drm_display_mode *mode)
> 
> Signed-off-by: Xiongwei Song <sxwjean@gmail.com>

Thanks, I'll pick this up for the next pull request.

Best regards,
Jyri


> ---
>  drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> index 6ef4d1a..c4804d9 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c
> @@ -294,7 +294,7 @@ static void tilcdc_crtc_set_clk(struct drm_crtc *crtc)
>  				LCDC_V2_CORE_CLK_EN);
>  }
>  
> -uint tilcdc_mode_hvtotal(const struct drm_display_mode *mode)
> +static uint tilcdc_mode_hvtotal(const struct drm_display_mode *mode)
>  {
>  	return (uint) div_u64(1000llu * mode->htotal * mode->vtotal,
>  			      mode->clock);
> 


-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki