Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753636AbdLDIb2 (ORCPT ); Mon, 4 Dec 2017 03:31:28 -0500 Received: from mail.netline.ch ([148.251.143.178]:34498 "EHLO netline-mail3.netline.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751205AbdLDIbY (ORCPT ); Mon, 4 Dec 2017 03:31:24 -0500 Subject: Re: [PATCH] platform/x86: hp-wmi: Actually use mask parameter in hp_wmi_hw_state To: Darren Hart Cc: Andy Shevchenko , Andy Shevchenko , Platform Driver , "linux-kernel@vger.kernel.org" References: <20171128151758.9234-1-michel@daenzer.net> <20171128165724.GA16349@fury> <20171201193929.GA18881@fury> From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Message-ID: <406921d4-0052-19f1-e949-c8026d9cc22d@daenzer.net> Date: Mon, 4 Dec 2017 09:31:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171201193929.GA18881@fury> Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2167 Lines: 53 On 2017-12-01 08:39 PM, Darren Hart wrote: > On Tue, Nov 28, 2017 at 08:41:47PM +0100, Michel Dänzer wrote: >> On 2017-11-28 08:30 PM, Andy Shevchenko wrote: >>> On Tue, Nov 28, 2017 at 8:06 PM, Michel Dänzer wrote: >>>> On 2017-11-28 05:57 PM, Darren Hart wrote: >>>>> On Tue, Nov 28, 2017 at 04:17:58PM +0100, Michel Dänzer wrote: >>>>>> We were always checking bit 0 (which represents the docked state) >>>>>> regardless of the mask. >>>>>> >>>>>> Fixes the "tablet mode" state always being reported the same as the >>>>>> docked state, which with current libinput can cause the built-in input >>>>>> devices of laptops to be incorrectly disabled while docked. >>> >>>>> Merged in 4.15-rc1 >>>> >>>> AFAIK commits without >>>> >>>> Cc: stable@vger.kernel.org >>>> >>>> don't get automatically picked up for stable branches. Can you manually >>>> nominate 9968e12 for stable? >>> >>> AFAIK Greg picks up patches based on Fixes tag as well. >>> Feel free to ping us or just forward that one yourself if Greg will >>> not pick up in reasonable (month?) time. >> >> Both 4.14.1 and 4.14.2 were released after Linus merged the fix, but > > Based on Documentation/process/stable-kernel-rules.rst, this seems unlikely to > happen automatically. Right, because there's no Cc: stable@vger.kernel.org in the commit log, that was my point above. :) >> neither has it. Given that, and that a fair number of people seem to be >> running into this, seems like a good idea to do it ASAP. > > This is our responsibility to check if patches are candidates for stable, and > the Fixes tag should be a trigger for us, the maintainers, to do that check. > Sometimes we miss things, sometimes the dependencies are more than they are > worth. In this case, we just missed it. > > You can just send this in yourself using the original fix and following the > process in stable-kernel-rules.rst. I did, and Greg picked it up promptly. I forgot to Cc you guys on the nomination e-mail, sorry about that. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer