Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753509AbdLDIeu (ORCPT ); Mon, 4 Dec 2017 03:34:50 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:58452 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753236AbdLDIet (ORCPT ); Mon, 4 Dec 2017 03:34:49 -0500 Date: Mon, 4 Dec 2017 09:34:42 +0100 From: Hendrik Brueckner To: Alexei Starovoitov Cc: Hendrik Brueckner , Arnaldo Carvalho de Melo , Daniel Borkmann , Martin Schwidefsky , Will Deacon , Ingo Molnar , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, netdev@vger.kernel.org, Peter Zijlstra , "David S. Miller" , Heiko Carstens Subject: Re: [PATCH 1/5] bpf: correct broken uapi for BPF_PROG_TYPE_PERF_EVENT program type References: <1512137948-31729-1-git-send-email-brueckner@linux.vnet.ibm.com> <1512137948-31729-2-git-send-email-brueckner@linux.vnet.ibm.com> <20171203175108.oo75sszrmpdvtukz@ast-mbp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171203175108.oo75sszrmpdvtukz@ast-mbp> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17120408-0008-0000-0000-000004B30C17 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17120408-0009-0000-0000-00001E45FAB2 Message-Id: <20171204083442.GA3952@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-12-04_02:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1709140000 definitions=main-1712040126 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1832 Lines: 57 Hi Alexei, On Sun, Dec 03, 2017 at 09:51:10AM -0800, Alexei Starovoitov wrote: > On Fri, Dec 01, 2017 at 03:19:04PM +0100, Hendrik Brueckner wrote: > > --- a/include/uapi/linux/bpf_perf_event.h > > +++ b/include/uapi/linux/bpf_perf_event.h > > @@ -8,11 +8,10 @@ > > #ifndef _UAPI__LINUX_BPF_PERF_EVENT_H__ > > #define _UAPI__LINUX_BPF_PERF_EVENT_H__ > > > > -#include > > -#include > > +#include > > > > struct bpf_perf_event_data { > > - struct pt_regs regs; > > + bpf_user_pt_regs_t regs; > > __u64 sample_period; > > }; > > Thank you for working on this problem. > The fix looks great to me. Thank you. > While applying it I noticed few nits: > Applying: selftests/bpf: sync kernel headers and introduce arch support in Makefile > /w/bpf/.git/rebase-apply/patch:253: trailing whitespace. > freg_t fprs[NUM_FPRS]; > /w/bpf/.git/rebase-apply/patch:262: trailing whitespace. > typedef struct > /w/bpf/.git/rebase-apply/patch:439: trailing whitespace. > } lowcore; > /w/bpf/.git/rebase-apply/patch:490: trailing whitespace. > } ptprot_area; > warning: 4 lines add whitespace errors. > > Could you please fix those and resubmit ? Sure will do. For that I have to add a clean-up patch for the s390 ptrace.h uapi header. > With that fixed feel free to add my > Acked-by: Alexei Starovoitov > to the patches. Thank you very much, will do! > I've tested it on arm64 and don't see any issues. I got a nice message from the build bot, I have some more work on that. So will respin the series, add you Acked-by, and sent a v2 around. > When resubmitting could you please reduce cc-list, since this set > went into spam folder for me and I noticed it only in patchworks. Will do... I just used what get_maintainers.pl told me :)