Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752830AbdLDIrN (ORCPT ); Mon, 4 Dec 2017 03:47:13 -0500 Received: from mail-vk0-f65.google.com ([209.85.213.65]:42269 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752968AbdLDIrJ (ORCPT ); Mon, 4 Dec 2017 03:47:09 -0500 X-Google-Smtp-Source: AGs4zMbHmO+iJdJ9yDLoNjdiBx/jalLmPBozg04daL06HMBVW0GQ5sHX7zeo8oeOPAn2hXIOlZ1eV6cvsy3b/BY13us= MIME-Version: 1.0 In-Reply-To: <20171201121934.GA3352@dhcp-128-65.nay.redhat.com> References: <20171201121934.GA3352@dhcp-128-65.nay.redhat.com> From: Benjamin Tissoires Date: Mon, 4 Dec 2017 09:47:08 +0100 Message-ID: Subject: Re: [PATCH v2] HID: add quirk for another PIXART OEM mouse used by HP To: Dave Young Cc: Jiri Kosina , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3308 Lines: 52 On Fri, Dec 1, 2017 at 1:19 PM, Dave Young wrote: > This mouse keep disconnecting in runleve 3 like below, add it needs the > quirk to mute the anoying messages. > > [ 111.230555] usb 2-2: USB disconnect, device number 6 > [ 112.718156] usb 2-2: new low-speed USB device number 7 using xhci_hcd > [ 112.941594] usb 2-2: New USB device found, idVendor=03f0, idProduct=094a > [ 112.984866] usb 2-2: New USB device strings: Mfr=1, Product=2, SerialNumber=0 > [ 113.027731] usb 2-2: Product: HP USB Optical Mouse > [ 113.069977] usb 2-2: Manufacturer: PixArt > [ 113.113500] input: PixArt HP USB Optical Mouse as /devices/pci0000:00/0000:00:14.0/usb2/2-2/2-2:1.0/0003:03F0:094A.0002/input/input14 > [ 113.156787] hid-generic 0003:03F0:094A.0002: input: USB HID v1.11 Mouse [PixArt HP USB Optical Mouse] on usb-0000:00:14.0-2/input0 > [ 173.262642] usb 2-2: USB disconnect, device number 7 > [ 174.750244] usb 2-2: new low-speed USB device number 8 using xhci_hcd > [ 174.935740] usb 2-2: New USB device found, idVendor=03f0, idProduct=094a > [ 174.990435] usb 2-2: New USB device strings: Mfr=1, Product=2, SerialNumber=0 > [ 175.014984] usb 2-2: Product: HP USB Optical Mouse > [ 175.037886] usb 2-2: Manufacturer: PixArt > [ 175.061794] input: PixArt HP USB Optical Mouse as /devices/pci0000:00/0000:00:14.0/usb2/2-2/2-2:1.0/0003:03F0:094A.0003/input/input15 > [ 175.084946] hid-generic 0003:03F0:094A.0003: input: USB HID v1.11 Mouse [PixArt HP USB Optical Mouse] on usb-0000:00:14.0-2/input0 > > Signed-off-by: Dave Young > Cc: stable@vger.kernel.org > --- Reviewed-by: Benjamin Tissoires > v1->v2: rebase to usb tree hid-quirks-cleanup branch > drivers/hid/hid-ids.h | 1 + > drivers/hid/hid-quirks.c | 1 + > 2 files changed, 2 insertions(+) > > --- linux-x86.orig/drivers/hid/hid-ids.h > +++ linux-x86/drivers/hid/hid-ids.h > @@ -535,6 +535,7 @@ > #define USB_PRODUCT_ID_HP_LOGITECH_OEM_USB_OPTICAL_MOUSE_0A4A 0x0a4a > #define USB_PRODUCT_ID_HP_LOGITECH_OEM_USB_OPTICAL_MOUSE_0B4A 0x0b4a > #define USB_PRODUCT_ID_HP_PIXART_OEM_USB_OPTICAL_MOUSE 0x134a > +#define USB_PRODUCT_ID_HP_PIXART_OEM_USB_OPTICAL_MOUSE_094A 0x094a > > #define USB_VENDOR_ID_HUION 0x256c > #define USB_DEVICE_ID_HUION_TABLET 0x006e > --- linux-x86.orig/drivers/hid/hid-quirks.c > +++ linux-x86/drivers/hid/hid-quirks.c > @@ -90,6 +90,7 @@ const struct hid_device_id hid_quirks[] > { HID_USB_DEVICE(USB_VENDOR_ID_HP, USB_PRODUCT_ID_HP_LOGITECH_OEM_USB_OPTICAL_MOUSE_0A4A), HID_QUIRK_ALWAYS_POLL }, > { HID_USB_DEVICE(USB_VENDOR_ID_HP, USB_PRODUCT_ID_HP_LOGITECH_OEM_USB_OPTICAL_MOUSE_0B4A), HID_QUIRK_ALWAYS_POLL }, > { HID_USB_DEVICE(USB_VENDOR_ID_HP, USB_PRODUCT_ID_HP_PIXART_OEM_USB_OPTICAL_MOUSE), HID_QUIRK_ALWAYS_POLL }, > + { HID_USB_DEVICE(USB_VENDOR_ID_HP, USB_PRODUCT_ID_HP_PIXART_OEM_USB_OPTICAL_MOUSE_094A), HID_QUIRK_ALWAYS_POLL }, > { HID_USB_DEVICE(USB_VENDOR_ID_IDEACOM, USB_DEVICE_ID_IDEACOM_IDC6680), HID_QUIRK_MULTI_INPUT }, > { HID_USB_DEVICE(USB_VENDOR_ID_INNOMEDIA, USB_DEVICE_ID_INNEX_GENESIS_ATARI), HID_QUIRK_MULTI_INPUT }, > { HID_USB_DEVICE(USB_VENDOR_ID_KYE, USB_DEVICE_ID_KYE_EASYPEN_M610X), HID_QUIRK_MULTI_INPUT },