Date: Mon, 4 Dec 2017 11:04:23 +0100
From: Simon =?utf-8?Q?Sandstr=C3=B6m?= <simon@nikanor.nu>
To: Marcus Wolf <marcus.wolf@smarthome-wolf.de>
Cc: gregkh@linuxfoundation.org, linux@Wolf-Entwicklungen.de,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in
 rf69_enum.h
Message-ID: <20171204100422.tsivp7lyayhflqe5@gamma.nikanor.nu>
References: <20171203151726.16639-1-simon@nikanor.nu>
 <20171203151726.16639-5-simon@nikanor.nu>
 <4419d69e-dc2d-6944-752f-d925c8223b96@smarthome-wolf.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4419d69e-dc2d-6944-752f-d925c8223b96@smarthome-wolf.de>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1237
Lines: 39

On Sun, Dec 03, 2017 at 06:49:40PM +0200, Marcus Wolf wrote:
> 
> Hi Simon,
Hi,

> 
> thanks for your effort.
> 
> I have two questions:
> * According to my practical experiance, enums were always written in lower
> case. Does kernel style guide ask for upper case for enums?
Yes. From Documentation/process/coding-style.rst: "Names of macros
defining constants and labels in enums are capitalized". 

> For me upper case indicates, that this value will be processed by
> preprocessor, not by compiler. So I used it for define constants and macros
> so far...
For me a upper case identifier indicates something that has a constant
value. Therefore I think it makes sense that enum labels are
capitalized.

> * The enums are the interface to user space. Isn't it necessary to increse
> the interface version number on every change of the enums?
> Or can we stay with old version number, since order of the enums is
> untouched?
Good question. I read the note about having to change ioctl number if
the contents of the struct ever change, but is this also true if only
the name of a variable change? I mean, the actual content is still the
same.

I will investigate this more and get back to you.

> 
> Thanks,
> 
> Marcus

Regards,
Simon