Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753363AbdLDKNu (ORCPT ); Mon, 4 Dec 2017 05:13:50 -0500 Received: from mail.us.es ([193.147.175.20]:60276 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752886AbdLDKNp (ORCPT ); Mon, 4 Dec 2017 05:13:45 -0500 Date: Mon, 4 Dec 2017 11:13:40 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Linus =?iso-8859-1?Q?L=FCssing?= Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org, Florian Westphal , linux-kernel@vger.kernel.org, coreteam@netfilter.org, netfilter-devel@vger.kernel.org, Jozsef Kadlecsik , "David S . Miller" Subject: Re: [Bridge] [PATCH net-next] bridge: ebtables: Avoid resetting limit rule state Message-ID: <20171204101340.GA7871@salvia> References: <20171125074418.16537-1-linus.luessing@c0d3.blue> <20171127233008.GA1418@salvia> <20171204045335.GE3307@otheros> <20171204052006.GF3307@otheros> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20171204052006.GF3307@otheros> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 792 Lines: 21 On Mon, Dec 04, 2017 at 06:20:06AM +0100, Linus L?ssing wrote: > On Mon, Dec 04, 2017 at 05:53:35AM +0100, Linus L?ssing wrote: > > And so, no I do not have this patch. I looked at it now, but it > > does not seem to have any relation with .matchinfo, does it? > > Relation between .usersize and .checkentry I ment, not > .usersize and .matchinfo. In your patch, info->prev comes set to a value from userspace, right? commit 324318f0248c31be8a08984146e7e4dd7cdd091d Author: Willem de Bruijn Date: Tue May 9 16:17:37 2017 -0400 netfilter: xtables: zero padding in data_to_user Since that patch above, the data area is zero'ed before dumped to userspace, so we would get a null info->prev, hence defeating the trick your patch relies on. Am I missing anything?