Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753891AbdLDLwC (ORCPT ); Mon, 4 Dec 2017 06:52:02 -0500 Received: from mga06.intel.com ([134.134.136.31]:31024 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752736AbdLDLv6 (ORCPT ); Mon, 4 Dec 2017 06:51:58 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,359,1508828400"; d="scan'208";a="12812817" Subject: Re: [PATCH] PM / runtime: Fix handling of suppliers with disabled runtime PM To: "Rafael J. Wysocki" , Linux PM Cc: LKML , Lukas Wunner , Greg Kroah-Hartman References: <1532136.s6buYvDjaS@aspire.rjw.lan> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Mon, 4 Dec 2017 13:51:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1532136.s6buYvDjaS@aspire.rjw.lan> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1395 Lines: 36 On 01/12/17 15:58, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Prevent rpm_get_suppliers() from returning an error code if runtime > PM is disabled for one or more of the supplier devices it wants to > runtime-resume, so as to make runtime PM work for devices with links > to suppliers that don't use runtime PM (such links may be created > during device enumeration even before it is known whether or not > runtime PM will be enabled for the devices in question, for example). > > Reported-by: Adrian Hunter > Fixes: 21d5c57b3726 (PM / runtime: Use device links) > Signed-off-by: Rafael J. Wysocki Tested-by: Adrian Hunter > --- > drivers/base/power/runtime.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Index: linux-pm/drivers/base/power/runtime.c > =================================================================== > --- linux-pm.orig/drivers/base/power/runtime.c > +++ linux-pm/drivers/base/power/runtime.c > @@ -276,7 +276,8 @@ static int rpm_get_suppliers(struct devi > continue; > > retval = pm_runtime_get_sync(link->supplier); > - if (retval < 0) { > + /* Ignore suppliers with disabled runtime PM. */ > + if (retval < 0 && retval != -EACCES) { > pm_runtime_put_noidle(link->supplier); > return retval; > } > >