Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753766AbdLDMl4 (ORCPT ); Mon, 4 Dec 2017 07:41:56 -0500 Received: from mail-wr0-f193.google.com ([209.85.128.193]:43079 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753637AbdLDMlu (ORCPT ); Mon, 4 Dec 2017 07:41:50 -0500 X-Google-Smtp-Source: AGs4zMbW6fPwS622uMtmDOtHuP4LbElOeMqoWdKOX9yIss5nYrKcQajxBj+yTsj09o0C5zj/wv9tUww0AQLaOioIqp4= MIME-Version: 1.0 In-Reply-To: <1512382405-14774-3-git-send-email-oleksandrs@mellanox.com> References: <1512382405-14774-1-git-send-email-oleksandrs@mellanox.com> <1512382405-14774-3-git-send-email-oleksandrs@mellanox.com> From: Philippe Ombredanne Date: Mon, 4 Dec 2017 13:41:08 +0100 Message-ID: Subject: Re: [patch v13 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx families JTAG master driver To: Oleksandr Shamray Cc: Greg Kroah-Hartman , Arnd Bergmann , LKML , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , OpenBMC Maillist , joel@jms.id.au, =?UTF-8?B?SmnFmcOtIFDDrXJrbw==?= , Tobias Klauser , linux-serial@vger.kernel.org, vadimp@mellanox.com, system-sw-low-level@mellanox.com, Rob Herring , openocd-devel-owner@lists.sourceforge.net, linux-api@vger.kernel.org, "David S. Miller" , Mauro Carvalho Chehab , Jiri Pirko Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1388 Lines: 43 Oleksandr, On Mon, Dec 4, 2017 at 11:13 AM, Oleksandr Shamray wrote: [...] > v12->v13 > Comments pointed by Philippe Ombredanne > - Change jtag-aspeed.c licence type to > SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note > and reorder line with license in description [...] > diff --git a/drivers/jtag/jtag-aspeed.c b/drivers/jtag/jtag-aspeed.c > new file mode 100644 > index 0000000..2ff46b0 > --- /dev/null > +++ b/drivers/jtag/jtag-aspeed.c > @@ -0,0 +1,784 @@ > +/* SPDX-License-Identifier: GPL-2.0 Sorry to nit pick on this but the comment style should be // here IMHO This is what Linus requested, e.g.: > +// SPDX-License-Identifier: GPL-2.0 For reference, the doc is being written:Thomas (tglx) has already submitted a first series of doc patches a few weeks ago. And AFAIK he might be working on posting the updates soon, whenever his real time clock yields a few cycles away from real time coding work ;) See also these discussions with Linus [1][2][3], Thomas[4] and Greg[5] on this and mostly related topics, where you will see Linus rationale for the C++ comment stylle [1] https://lkml.org/lkml/2017/11/2/715 [2] https://lkml.org/lkml/2017/11/25/125 [3] https://lkml.org/lkml/2017/11/25/133 [4] https://lkml.org/lkml/2017/11/2/805 [5] https://lkml.org/lkml/2017/10/19/165 -- Cordially Philippe Ombredanne