Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753619AbdLDNV5 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 4 Dec 2017 08:21:57 -0500
Received: from galahad.ideasonboard.com ([185.26.127.97]:37800 "EHLO
        galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753157AbdLDNVy (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 4 Dec 2017 08:21:54 -0500
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Brian Norris <briannorris@chromium.org>
Cc: heiko@sntech.de, Archit Taneja <architt@codeaurora.org>,
        Andrzej Hajda <a.hajda@samsung.com>, David Airlie <airlied@linux.ie>,
        Yannick Fertre <yannick.fertre@st.com>,
        Philippe Cornu <philippe.cornu@st.com>,
        Benjamin Gaignard <benjamin.gaignard@linaro.org>,
        Vincent Abriou <vincent.abriou@st.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Sean Paul <seanpaul@chromium.org>,
        Nickey Yang <nickey.yang@rock-chips.com>, hl@rock-chips.com,
        linux-rockchip@lists.infradead.org, mka@chromium.org,
        Doug Anderson <dianders@chromium.org>, robh+dt@kernel.org,
        mark.rutland@arm.com, hoegsberg@gmail.com, zyw@rock-chips.com,
        xbl@rock-chips.com
Subject: Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399
Date: Mon, 04 Dec 2017 15:22:07 +0200
Message-ID: <13507001.EQOuo8KY2k@avalon>
Organization: Ideas on Board Oy
In-Reply-To: <20171129184755.77187-1-briannorris@chromium.org>
References: <20171129184755.77187-1-briannorris@chromium.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1322
Lines: 48

Hi Nickey,

Thank you for the patch.

On Wednesday, 29 November 2017 20:47:55 EET Brian Norris wrote:
> From: Nickey Yang <nickey.yang@rock-chips.com>
> 
> We might include additional ports in derivative device trees, so the
> 'port' node should have an address, and the parent 'ports' node needs
> /#{addres,size}-cells.
> 
> v4:
>  * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
>  * separate from the rest of the series, since this is mostly
>    independent of the driver refactoring
> 
> Signed-off-by: Nickey Yang <nickey.yang@rock-chips.com>
> Signed-off-by: Brian Norris <briannorris@chromium.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index d340b58ab184..c6dae25a3f23
> 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1652,7 +1652,11 @@
>  		status = "disabled";
> 
>  		ports {
> -			mipi_in: port {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			mipi_in: port@0 {
> +				reg = <0>;
>  				#address-cells = <1>;
>  				#size-cells = <0>;


-- 
Regards,

Laurent Pinchart