Subject: Re: [PATCH 0/9] media: imx: Add better OF graph support
To: Steve Longerbeam <slongerbeam@gmail.com>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org,
        Russell King <rmk+kernel@armlinux.org.uk>,
        Steve Longerbeam <steve_longerbeam@mentor.com>
References: <1509223009-6392-1-git-send-email-steve_longerbeam@mentor.com>
From: Hans Verkuil <hverkuil@xs4all.nl>
Message-ID: <c20882c4-8a61-c2b1-6664-171f9bfbcaa6@xs4all.nl>
Date: Mon, 4 Dec 2017 14:44:57 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <1509223009-6392-1-git-send-email-steve_longerbeam@mentor.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3013
Lines: 69

Hi Steve,

On 10/28/2017 10:36 PM, Steve Longerbeam wrote:
> This is a set of patches that improve support for more complex OF
> graphs. Currently the imx-media driver only supports a single device
> with a single port connected directly to either the CSI muxes or the
> MIPI CSI-2 receiver input ports. There can't be a multi-port device in
> between. This patch set removes those limitations.
> 
> For an example taken from automotive, a camera sensor or decoder could
> be literally a remote device accessible over a FPD-III link, via TI
> DS90Ux9xx deserializer/serializer pairs. This patch set would support
> such OF graphs.
> 
> There are still some assumptions and restrictions, regarding the equivalence
> of device-tree ports, port parents, and endpoints to media pads, entities,
> and links that have been enumerated in the TODO file.

Before I merge this patch series I wanted to know if Sakari's async work
that has now been merged (see https://www.spinics.net/lists/linux-media/msg124082.html)
affects this patch series.

It still applies cleanly, but I wondered if the subnotifier improvements
would simplify this driver.

Of course, any such simplification can also be done after this series has
been applied, but I don't know what your thoughts are on this.

Regards,

	Hans

> This patch set supersedes the following patches submitted earlier:
> 
> "[PATCH v2] media: staging/imx: do not return error in link_notify for unknown sources"
> "[PATCH RFC] media: staging/imx: fix complete handler"
> 
> Tested by: Steve Longerbeam <steve_longerbeam@mentor.com>
> on SabreLite with the OV5640
> 
> Tested-by: Philipp Zabel <p.zabel@pengutronix.de>
> on Nitrogen6X with the TC358743.
> 
> Tested-by: Russell King <rmk+kernel@armlinux.org.uk>
> with the IMX219
> 
> 
> Steve Longerbeam (9):
>   media: staging/imx: get CSI bus type from nearest upstream entity
>   media: staging/imx: remove static media link arrays
>   media: staging/imx: of: allow for recursing downstream
>   media: staging/imx: remove devname string from imx_media_subdev
>   media: staging/imx: pass fwnode handle to find/add async subdev
>   media: staging/imx: remove static subdev arrays
>   media: staging/imx: convert static vdev lists to list_head
>   media: staging/imx: reorder function prototypes
>   media: staging/imx: update TODO
> 
>  drivers/staging/media/imx/TODO                    |  63 +++-
>  drivers/staging/media/imx/imx-ic-prp.c            |   4 +-
>  drivers/staging/media/imx/imx-media-capture.c     |   2 +
>  drivers/staging/media/imx/imx-media-csi.c         | 187 +++++-----
>  drivers/staging/media/imx/imx-media-dev.c         | 400 ++++++++++------------
>  drivers/staging/media/imx/imx-media-internal-sd.c | 253 +++++++-------
>  drivers/staging/media/imx/imx-media-of.c          | 278 ++++++++-------
>  drivers/staging/media/imx/imx-media-utils.c       | 122 +++----
>  drivers/staging/media/imx/imx-media.h             | 187 ++++------
>  9 files changed, 722 insertions(+), 774 deletions(-)
>