Date: Mon, 04 Dec 2017 09:20:45 -0600
Message-ID: <20171204092045.Horde.5M1LmPnqkpe4as2CWf9PPSh@gator4166.hostgator.com>
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
To: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>, David Airlie <airlied@linux.ie>,
        intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH] drm/i915: Mark expected switch fall-throughs
References: <20171127221701.GA15983@embeddedor.com>
 <1512383705.4394.18.camel@linux.intel.com>
In-Reply-To: <1512383705.4394.18.camel@linux.intel.com>
User-Agent: Horde Application Framework 5
Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes
MIME-Version: 1.0
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 805
Lines: 32

Hi Joonas,

Quoting Joonas Lahtinen <joonas.lahtinen@linux.intel.com>:

> On Mon, 2017-11-27 at 16:17 -0600, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>
> I have to say I'm totally not sold on regexps matching comment
> contents. Was something more explicit ever considered? Like:
>
> #define FALLTHROUGH __attribute__((fallthrough));
>
> With the appropriate version checks, of course.
>

One of the arguments is that comments lets us leverage the existing  
static analyzers.

We've been discussing this during the last week, feel free to join the  
discussion:

http://www.spinics.net/lists/kernel/msg2659908.html
http://www.spinics.net/lists/kernel/msg2659906.html

Thanks!
--
Gustavo A. R. Silva