Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752945AbdLDQyZ (ORCPT ); Mon, 4 Dec 2017 11:54:25 -0500 Received: from mail-eopbgr10109.outbound.protection.outlook.com ([40.107.1.109]:56889 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752877AbdLDQwR (ORCPT ); Mon, 4 Dec 2017 11:52:17 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH v3 3/5] kasan: support alloca() poisoning To: Christoph Hellwig , Paul Lawrence Cc: Alexander Potapenko , Dmitry Vyukov , Masahiro Yamada , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kbuild@vger.kernel.org, Matthias Kaehlcke , Michael Davidson , Greg Hackmann References: <20171201213643.2506-1-paullawrence@google.com> <20171201213643.2506-4-paullawrence@google.com> <20171204164240.GA24425@infradead.org> From: Andrey Ryabinin Message-ID: Date: Mon, 4 Dec 2017 19:55:37 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171204164240.GA24425@infradead.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: HE1PR0701CA0080.eurprd07.prod.outlook.com (2603:10a6:3:64::24) To VI1PR08MB2829.eurprd08.prod.outlook.com (2603:10a6:802:19::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2db3742f-7078-4678-fef8-08d53b375e72 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(7168020)(4627115)(201703031133081)(201702281549075)(2017052603286);SRVR:VI1PR08MB2829; X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB2829;3:bQ62zs9lx9LkuvZ9SCbNJBm/124TD9o1XmmmH0mYS123FBRjToNCc1xrR8i5uc+s/haVYI/gJH0HIVXYQHWR5Ex5czY4/2L0TsQ6opaVbP54v9noqqemeliGx/XyfzUuHVTTwTsm8FopEDcB5ite3Hpvg1Pfl5z0Nf52r2ME+NqIedGLx1wojn/F90wpy1W/EqNvMkL6m20jd37MNhYK4wofyjHNKuyGBXBAtESw0M1mv2lm8I1wwZqKbLs8vMLH;25:APh5VLcabvhFX10RAlXwtO9+j22rsxsituQxYeHRQ3wRIIwmaY4bquZs9A99IPUANpzxMlLktI8QnksltVgq2PiO+W600lGZUa9pU3TUcUIbLaPNLdZvPtKgh4nRVpl4PFqBZ7OM7naxIfU9HCwtLdtgisP+E9d23kt3oIe3NSQI8iMMENQ9sKX6Y3athCmGo26TUmcnFO0OydolDDGDkiXqIrfn/FI6X3JGOoCGdvgt2VRvvt8FjcJ5yC8VINOi98hi13SlqyMbkw5Y54x5dL63i/mm1s9aIt8w6Vov2V8ABaqj6Y9koPJqagJEty+MYQSWhCeyTFuvmeuJoyZ3aQ==;31:t+RXs9e0opdfd7RQX3QPS2Y/GrL8EkZ0vnFD4Oo1jJaCeYwW2SXA33LQpURrXsfqKmgBuj7Skf0HzHRRNQWtOoYt7L+xuuS9mA6RcyFU5bdTa95vhP1HGziMtttH13N5rDbA/9YD7gnDgrJgKCMwL0uKJXuTEliKbnfb2J+5bLphomFUMp9FIzdKTfvCQzV07Ghscv6RSepDAB/C32ECUjbGJtaj62hNBqDwkCDnw2c= X-MS-TrafficTypeDiagnostic: VI1PR08MB2829: X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB2829;20:QbjN/7QK16j/Y5OHxx2dhp7+WUdXPfYiVFOQuLpEa8iv615FGpQN/81qD77Bd4rNR+92Hs2vTxiy2MrH3oevPrvWc70hF6yTFYGXQ6gx965tDn3vmkso155pI+WUh0+PUFrwVObGR3Kw5QWaLlI2dHSaPMrmrd78hQDoITPGkbSpuWEDJzPHjNuV1sTar+e7ueUFdqcqUR12A3IBA3SQLLyNL9bebfVm2s6K37mvL+fPkIY31LwFMBK4UrAFSXrC5rnX0NPuE8dn6eM+TIU4g2Mz5shDW7w2mhtvj+I0xadbJriHceqS1GfRVhRTWzqfxd368f0n+crERxi5ACQ2gWcMrxzDN8tAokMwLdSyoR9GOeJLwCs8qgCGNcph64ikY61o1xfdx9WqGMF3dVphx1N3KVwetxY/TDDBYdMVEew=;4:pmW2Bshgz2sgitX8Y4huHzqNxE/2TPsvXyj2Cla/0vk9S/d5aBRD1yuRhAhD1a51UDAoht2jb/o90tzHTx2awVWggDXtL63L91+TWSyPYXjjLkVlIrGzCgVfJtA3M6mqb3BppS2a6Sza5OkePvbUCqngJ4q/5QU4sVR4VKTkfw8CnhHshR0oTxBXTXanAWU0BsgcU+m+E2BZbLGNOZEbPTsvT0MGEcGbk22Qwo+q6W9QrrCUEbjhP5syl7SSvXScAb0gq58coyZ6bOg3uorSqA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(3231022)(6041248)(20161123564025)(20161123562025)(20161123560025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011);SRVR:VI1PR08MB2829;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:VI1PR08MB2829; X-Forefront-PRVS: 051158ECBB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(6009001)(6049001)(346002)(376002)(366004)(199003)(189002)(24454002)(54906003)(68736007)(54356011)(2486003)(7736002)(23676004)(52146003)(53546010)(25786009)(2906002)(6246003)(6116002)(189998001)(47776003)(3846002)(65956001)(65806001)(97736004)(4326008)(66066001)(16576012)(7416002)(110136005)(53936002)(31686004)(478600001)(558084003)(316002)(50466002)(81156014)(8676002)(55236003)(230700001)(58126008)(6486002)(101416001)(33646002)(81166006)(86362001)(2950100002)(31696002)(76176011)(65826007)(64126003)(16526018)(5660300001)(105586002)(106356001)(8936002)(305945005)(52116002)(83506002)(229853002)(36756003)(6666003)(77096006);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR08MB2829;H:[172.16.25.12];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA4TUIyODI5OzIzOjlFZmU3MHRXeWhkL2t5dEdqc1NPZTBKL1NP?= =?utf-8?B?RXpKbFFPS1YyckI1SHRPcFRFSW5SQzdrMUV6VVpiWGdwY1JpMkNHNDlSVnZH?= =?utf-8?B?QXJLOFRTcVZYSEEwT3RIb2FGY3R4Y29wMnVJOXV5a1NaMUJxVndQM3dOTnRE?= =?utf-8?B?VGgyRXFMTEpMSUZ3VUlwUmFYdFljNGVVekk4Tlp6OHNSa1g1L2ZsbFQ4RGNV?= =?utf-8?B?Z1dBY080MUpEWkxyWnpSMkIrU2ljdno4WGxkT2QxV3VqSTFVQzBWanYyd1B0?= =?utf-8?B?OFZPQyttcjgzOVZEckFDRldwamZhaDZTVzgxazA1d3daaXNaM1g2QmVBRW1y?= =?utf-8?B?TTdudU1BS3JGWGo1SGdueUxPVmdSV2grL2pOMEh1ZWhzYUkrM0dBTlJ5bmJV?= =?utf-8?B?MUc1cmU2UlBRUUVFTnM1MTBUM05YVVJJb0ZKTFV1bUxieUx3WTE0MjVZR1o1?= =?utf-8?B?Y3N3TjYwY211WVJSSUlOamZxYUw4VW9ETWxxVVAwWmNxWG1Sd20rbURLejE5?= =?utf-8?B?cHBvU3VUTi9CNEFxaFBOUEZkOU9NWUVuYVdraHF0T0RydXZIMElHYXhNQmhC?= =?utf-8?B?ZlNIOTZUekJSd0U1VEs0aE92UnpuZ0dmd0s0M1djUW1WTjBYN1NyaTg2Qmpl?= =?utf-8?B?aEhUTklVcGZiVjdaOWp2Tngzbk90VGpPeXhOU3JaUGdWMUNCc2U1cDZIZE5t?= =?utf-8?B?RzBmT3RFTFVnU3c2cTRCNmcwSUtEUEtFUnZWNHlvSSs3cXNTUU44Q1lJWWhH?= =?utf-8?B?cTRObmxzRXg1V1RydzBiUk5XQ0hiTlc2OXhBYllFVm80ZkIyTnUrczhVY2Y5?= =?utf-8?B?WlYwdUpHRGwvTWhCbGtleTB2WXNrcFNIUDRJajJOMkdLYS9Td2ZVbWRGMDY0?= =?utf-8?B?dWJmb2cxSVVGWmFFdUE2Wm1SclcwSVcvVzBIUHgrVWd1WlNpTFZrZ3VkMFV2?= =?utf-8?B?dVhKTk1wQ3ZjTUxkZG9mRG1iajFwT1lzV2Y2S2h2d3ZrZytMSVFOOUUxL05J?= =?utf-8?B?RkV3OGNNWjhPc1Vlam1uZFVJSjJmamJNb0NUV2NuUlIzTldaSnpmeEFaMnln?= =?utf-8?B?ZXJaV2VHdStTYUc4U1VJd0FQdktPcHdlU1lVOXpZTWRzZ3gxbUNQdlhLWnd2?= =?utf-8?B?eDE2R2trYk1OT2JEWlM2cXpZMVI3Z1NES1hFQkQ3QXZSVlVCczVOSnhXRkVT?= =?utf-8?B?Ui9MUThvUDFoS0JQYXp4SXVVZXhLN1FxRDkvS0pzTUNTZ3VMT0RpelNjL21w?= =?utf-8?B?YTFnUzN3MEVwaVRNZFdhTUlmOXhhSmtpVHhZL1dkeTBDWUJYQWlScnNYMnZM?= =?utf-8?B?dHBGS2FLK2FGckN0L1IyRWxRbXBoV0dCNFhXYlMyQXMxdVVBNGFvdSt4UGxt?= =?utf-8?B?eERaa2dvWHNWUEJXYVNjcHdtU0FhbEMwaEo3K0RoZGtEeGY0KzN3WmU1ZjdF?= =?utf-8?B?RHF1ZnBOVUl1bVhsRHhXU05YVlI5ekxFRnZ5a2hyQ0FVUDdPdnVaSkJSdXVG?= =?utf-8?B?aGZsUmZGdGNPdFVJdVRieC8yU0NJK096aldGVDQ5RWRLVExIdFA2amk4T2Vq?= =?utf-8?B?eGhqbkgyd0swZytxWkpodkpHMnZWbit5a2xCT24rRjdnQTJDNnZrWlU2Z2RR?= =?utf-8?B?YWt0UEVMaE9rbnVlbFB3OXFNTjJGdUVudmNLZmR0VUd4c1c5T05PM3lUZldM?= =?utf-8?B?cFpreTFvTVV3S0U0dEZFV0c1c2tHYmFEVUo0bTcvU0xHZlBqcTBtMDRBZ1Zk?= =?utf-8?B?OUFIV2t5Ym9zQVpIMnl3eGx5UzlpNllNQldhM1hpSGRhejBYRjhTUk82U0Zw?= =?utf-8?B?Yk1oczZuUTJqY0Z4ekFmK0NyT2ovM3V5MjVTSUY2cU9QTTNtci9BNEJsNXB1?= =?utf-8?B?OGQrOUZkcldLZFova21PSXpGc3NVM2F0eEUyanJnL2VYRk1SSHNqMGZtTG1K?= =?utf-8?B?clRDTzRER0xqbCtXajlDREJzZ2VMMnlwSUJsTHduemZhcGdJbC9yNkFEQmJC?= =?utf-8?Q?Wo5vkJ?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB2829;6:pWkMoprpZfWCEdULiL7lNilUbu8HimDPBQ7XbfxO02hAC22T98cQWWJg6n2HIATmIOlPgxsfn1HJ90j6oc5igdgQOKRLDhajqRcmKq+usRyyBc3ctd1r65U6UYI3ZNxd04k+NVN/+kMgEJoPii59IzHS0/xMFlWjttoHLKStBevhpU4qgrEYIGfbZlTA9KnNQgTbomUY08NyGSPKNcf745TNBbQOsZXO7ASTy8dkp582DuLg0PLTAW5b6lQd3N3J0qsQv7hzJ9APyyxueY5tK7T9kmvjJBm+7HHvt4SKXobyueG/BSbTrDA8YncT+3xmEzvn0NjNWtBvn5RXnO0NFKYDLZObhgZyXGe6fEBbRg8=;5:3MskrjLa6Nh+3n0Y7o2CWk9Hr6DN9S4DnNMAeWRpfEuimDG3V1vFgZzvPrhszlk1K8li75BYKiym0C0bPhS7oiddSSZAyOtNBQIjymZqDoe6/0tqq7h7Ib0AY1uRemGeuTbqimMreUOyZxqWs2EwqQjNpCJb3H4MfgaYPynXjkw=;24:DkyLteR9hrLp3tGs6RA71UackRWEmQuX1UR6F6RenhiqPhV8vTerv/Q0FIDMaMIkee5UAA9zSRAC+Owi45gHVPC0j6vdb3UO8qSsxxyjbl0=;7:U7n8AK1imT2zwmCCf0roHK236//2SKau8oLokE7tQWIl7RNOXQGgYO1v9G+6sIzypAUHCUSdSlUS/WLjXcTCFphyNm6LWaS5bE5ljZIn2L4u/xOAgICQbc6JHevimZCwBnR1PIIWu9lLuXM17Y3N72LwD7670VmzK1pBhkYMghAc5CQRkgg0Qab7a3ho3QDeo4rbBYMkz/k7AMVyphHDJZoIFl73Hl6vQXkJuABf/SKZh+jewD3++KTVC0y1TyF/ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR08MB2829;20:SDsf+UXN4ZLwip9Oz2a7OAYMfhcT5EVpaxTZXfkDCrc+sAQQlZZ8tx78LdubpaZkocok9fLGRNegKnUdTngO0U6INgFD7nvD7TcVEkiAVwNkbR84X0CDm3AFX9OETfd0U9cdYUpF/UBW4y7Ti1ywq46wvC93NywpQxGhjw/z23s= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2017 16:52:12.7409 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2db3742f-7078-4678-fef8-08d53b375e72 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB2829 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 306 Lines: 9 On 12/04/2017 07:42 PM, Christoph Hellwig wrote: > I don't think we are using alloca in kernel mode code, and we shouldn't. > What do I miss? Is this hidden support for on-stack VLAs? I thought > we'd get rid of them as well. > Yes, this is for on-stack VLA. Last time I checked, we still had a few.