Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752415AbdLDSpZ (ORCPT ); Mon, 4 Dec 2017 13:45:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:32619 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751380AbdLDSpW (ORCPT ); Mon, 4 Dec 2017 13:45:22 -0500 Date: Mon, 4 Dec 2017 11:45:21 -0700 From: Jerry Snitselaar To: Mathias Nyman Cc: gregkh@linuxfoundation.org, stern@rowland.harvard.edu, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: Don't print a warning if interface driver rebind is deferred at resume Message-ID: <20171204184521.im7la2tqke33cali@cantor> Reply-To: Jerry Snitselaar Mail-Followup-To: Mathias Nyman , gregkh@linuxfoundation.org, stern@rowland.harvard.edu, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20171118102835.GG8368@kroah.com> <1512389145-27213-1-git-send-email-mathias.nyman@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1512389145-27213-1-git-send-email-mathias.nyman@linux.intel.com> User-Agent: NeoMutt/20171027 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Mon, 04 Dec 2017 18:45:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1267 Lines: 35 On Mon Dec 04 17, Mathias Nyman wrote: >Interface drivers like btusb that don't support reset-resume will be >rebound at resume if port was reset. Rebind is done during the pm_ops >.complete callback when probe returns EPROBE_DEFER as default. > >Remove the "rebind failed: -517" message. >Device probe will eventually take place later. > >[one-liner by Jerry Snitselaar posted in a mailing list question -Mathias] >Suggested-by: Jerry Snitselaar >Signed-off-by: Mathias Nyman >--- > drivers/usb/core/driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/usb/core/driver.c b/drivers/usb/core/driver.c >index 64262a9a..5d34080 100644 >--- a/drivers/usb/core/driver.c >+++ b/drivers/usb/core/driver.c >@@ -1070,7 +1070,7 @@ static void usb_rebind_intf(struct usb_interface *intf) > if (!intf->dev.power.is_prepared) { > intf->needs_binding = 0; > rc = device_attach(&intf->dev); >- if (rc < 0) >+ if (rc < 0 && rc != -EPROBE_DEFER) > dev_warn(&intf->dev, "rebind failed: %d\n", rc); > } > } >-- >2.7.4 > Thanks for sending this. It looks like my filters sent the ensuing conversation off into never-never land or I wasn't cc'd and just missed it in the mailing lists.