Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752695AbdLDTNF (ORCPT <rfc822;w@1wt.eu>);
        Mon, 4 Dec 2017 14:13:05 -0500
Received: from dd39320.kasserver.com ([85.13.155.146]:33146 "EHLO
        dd39320.kasserver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752218AbdLDTNC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 4 Dec 2017 14:13:02 -0500
Subject: Re: [PATCH 5/6] staging: pi433: Rename enum dataMode in rf69_enum.h
To: Dan Carpenter <dan.carpenter@oracle.com>,
        =?UTF-8?Q?Simon_Sandstr=c3=b6m?= <simon@nikanor.nu>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux@Wolf-Entwicklungen.de, linux-kernel@vger.kernel.org
References: <20171203151726.16639-1-simon@nikanor.nu>
 <20171203151726.16639-6-simon@nikanor.nu>
 <20171204102419.onpiyz2dpos4ooc5@mwanda>
From: Marcus Wolf <marcus.wolf@smarthome-wolf.de>
Message-ID: <ab1d3ff4-e59d-d24f-7024-4c308738a281@smarthome-wolf.de>
Date: Mon, 4 Dec 2017 21:12:52 +0200
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171204102419.onpiyz2dpos4ooc5@mwanda>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: de-DE
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1769
Lines: 50



Am 04.12.2017 um 12:24 schrieb Dan Carpenter:
> On Sun, Dec 03, 2017 at 04:17:25PM +0100, Simon Sandström wrote:
>> Renames enum dataMode and its values packet, continuous, continuousNoSync
>> to enum data_mode and PACKET, CONTINUOUS, CONTINUOUS_NO_SYNC. Fixes
>> checkpatch.pl warnings: "Avoid CamelCase: <dataMode>, <continuousNoSync>".
> 
> These names are too generic.  Delete them.  Use DATAMODUL_MODE_PACKET
> and friends directly.
> 
> int rf69_set_data_mode(struct spi_device *spi, u8 val)
> {
> 	return WRITE_REG(REG_DATAMODUL, (READ_REG(REG_DATAMODUL) & ~MASK_DATAMODUL_MODE) | val);
> }
> 
> Only DATAMODUL_MODE_PACKET is ever used.  There is no need to validate
> the parameters.
> 
> regards,
> dan carpenter
> 

Hi Dan, hi Simon,

like I wrote a few days ago to Marcin Ciupak, I see two disadvantages in 
doing so.

If you want to go that way, you - as far as I believe - need to alter 
the values in rf69_enum.h, so they carry the corresponding values from 
rf69_reg.h. To avoid confusion, you will need to remove the values from 
rf69_reg.h.
But then you have to keep track of two files (enum.h and reg.h), if you 
want to further develop register access stuff. I would prefer to keep 
all chip/register related values at the same place.

Second there might be the idea of supporting different chips in the 
future (I already thought about).
Then it might be, that DATAMODUL_MODE_PACKET might need an other value.
Therefore, I introduced the "double layer" - enums as labels for the 
user space and defines, containing the values, for the register access.

For closer details, pls. see my long answer to Marcin.

I am not sure, whether simplification of the code like proposed is more 
important, then the disadvatages, I mentioned.

Cheers,

Marcus