Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752854AbdLDTPm (ORCPT <rfc822;w@1wt.eu>);
        Mon, 4 Dec 2017 14:15:42 -0500
Received: from userp1040.oracle.com ([156.151.31.81]:43201 "EHLO
        userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752065AbdLDTPl (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 4 Dec 2017 14:15:41 -0500
Date: Mon, 4 Dec 2017 22:15:22 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marcus Wolf <marcus.wolf@smarthome-wolf.de>
Cc: Simon =?iso-8859-1?Q?Sandstr=F6m?= <simon@nikanor.nu>,
        devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
        linux@Wolf-Entwicklungen.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in
 rf69_enum.h
Message-ID: <20171204191522.dcwclu7v7fig65nc@mwanda>
References: <20171203151726.16639-1-simon@nikanor.nu>
 <20171203151726.16639-5-simon@nikanor.nu>
 <20171204101737.xv4eyglsrbmiagtn@mwanda>
 <20171204103719.7talcb3dqu3yfns2@mwanda>
 <401fb0b7-48a9-dfc9-481b-d4e31f0ed9b5@smarthome-wolf.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <401fb0b7-48a9-dfc9-481b-d4e31f0ed9b5@smarthome-wolf.de>
User-Agent: NeoMutt/20170609 (1.8.3)
X-Source-IP: aserv0022.oracle.com [141.146.126.234]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1414
Lines: 46

On Mon, Dec 04, 2017 at 08:37:51PM +0200, Marcus Wolf wrote:
> 
> 
> Am 04.12.2017 um 12:37 schrieb Dan Carpenter:
> > On Mon, Dec 04, 2017 at 01:17:37PM +0300, Dan Carpenter wrote:
> > > Perhaps choose different function names if you want?  You could do it
> > > as several patches:
> > > 
> > > patch 1: change types to bool
> > > patch 2: sed -e '/ == optionOn//'
> > > patch 3: split the functions into two functions
> > > patch 4: delete optionOnOff enum
> > > 
> > > patches 1 and 2 could be merged together (your choice).
> > > 
> > 
> > Markus says that optionOn is used by user space so my you won't be able
> > to remove these entirely.  But as much as possible we should internally.
> > 
> > regards,
> > dan carpenter
> > 
> 
> Hi Dan, hi Simon,
> 
> I think, it's a pretty nice idea to remove th optionOnOff and replace it by
> bool.
> 
> <history>
> In former times, the variables in the config struct had very different names
> - not containing "enable". Therefore optionOnOff was used to make absolutely
> clear (in user space), wheter something was switched on, or off.
> Now the variable have nice names, so bool is fine, even better now :-)
> </history>
> 
> I would suggest not to split the amp-functions but to rename them, to also
> contain an enable:
> rf69_set_amp_X_enable()

That's a bad name, because it doesn't just enable it also disables.
Please split them.

regards,
dan carpenter