Subject: Re: [PATCH 5/6] staging: pi433: Rename enum dataMode in rf69_enum.h
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: =?UTF-8?Q?Simon_Sandstr=c3=b6m?= <simon@nikanor.nu>,
        gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
        linux@Wolf-Entwicklungen.de, linux-kernel@vger.kernel.org
References: <20171203151726.16639-1-simon@nikanor.nu>
 <20171203151726.16639-6-simon@nikanor.nu>
 <20171204102419.onpiyz2dpos4ooc5@mwanda>
 <ab1d3ff4-e59d-d24f-7024-4c308738a281@smarthome-wolf.de>
 <20171204192144.wnpcugnc23dohi7w@mwanda>
From: Marcus Wolf <marcus.wolf@smarthome-wolf.de>
Message-ID: <74a6813f-e7ad-e0e8-ca3d-392689664894@smarthome-wolf.de>
Date: Mon, 4 Dec 2017 21:31:06 +0200
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171204192144.wnpcugnc23dohi7w@mwanda>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: de-DE
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1109
Lines: 28

>> Second there might be the idea of supporting different chips in the future
>> (I already thought about).
> 
> Linux style is never to write code for the future.

Ok. I didn't know.
To be honest, I already started writing code, also supporting the rf12 
some time ago, thus programming a rfxx.c, but never finished, due to 
lack of time.
For getting stuff started, I need to focus on rf69 and pi433.

A few monthes ago, Hope RF (the producer of those chips) proposed me a 
new chip (can't remember the number - maybe 95), that also supports 
loraWan. Seems like there will be even more interesting chips coming up, 
that could be controlled with a similar interface implementation.

>> Then it might be, that DATAMODUL_MODE_PACKET might need an other value.
> 
> That's future code so we can delete that sentence for now.

With the rule above, you are absolutely right. But we now spend time, to 
remove an currently non necessary feature ("double layer"), which will 
take time to re-introduce as soon, as someone wants to support a second 
chip.
Isn't that double-work and a thus a pitty?

Cheers,
Marcus