Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751823AbdLDTkx (ORCPT ); Mon, 4 Dec 2017 14:40:53 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:34922 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751177AbdLDTkt (ORCPT ); Mon, 4 Dec 2017 14:40:49 -0500 X-Google-Smtp-Source: AGs4zMY5dmM5zbGteH7b6YaiIYP2BjZE8LxknL0Brc65P07BdDY/JqNyFWzZBNDEYF6sqb7jPFq6oA== Date: Mon, 4 Dec 2017 20:40:49 +0100 From: Christoffer Dall To: "Gomonovych, Vasyl" Cc: Christoffer Dall , Christoffer Dall , marc.zyngier@arm.com, eric.auger@redhat.com, andre.przywara@arm.com, wanghaibin.wang@huawei.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm: Use PTR_ERR_OR_ZERO() Message-ID: <20171204194049.GH32397@cbox> References: <1511909297-8585-1-git-send-email-gomonovych@gmail.com> <20171201080049.GB4218@cbox> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 521 Lines: 14 On Mon, Dec 04, 2017 at 12:11:22PM +0100, Gomonovych, Vasyl wrote: > Hi Christoffer > > It is just syntax sugar of course > and in mentioned function context it looks harmonically because it is > in the end of function return statement. > But in context of around source files it is looks not so harmonically because > existing code uses old approach. > And this old approach is only in one place here. > So it is just a try to fix the warning and may be force to use it in a > future changes. ok, thanks. -Christoffer