Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752599AbdLDUaE (ORCPT <rfc822;w@1wt.eu>);
        Mon, 4 Dec 2017 15:30:04 -0500
Received: from mail-oi0-f68.google.com ([209.85.218.68]:34954 "EHLO
        mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752211AbdLDUaB (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 4 Dec 2017 15:30:01 -0500
X-Google-Smtp-Source: AGs4zMZBIT33ItU4h6tBKvKDBJjiK3JK1AN7yzna1a60QaJV9iznMgtDFRvA33iQkRUVFPswkosWXA==
Date: Mon, 4 Dec 2017 14:29:59 -0600
From: Rob Herring <robh@kernel.org>
To: Tirupathi Reddy <tirupath@codeaurora.org>
Cc: sboyd@codeaurora.org, mturquette@baylibre.com, mark.rutland@arm.com,
        andy.gross@linaro.org, david.brown@linaro.org,
        linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-soc@vger.kernel.org
Subject: Re: [PATCH V7 2/2] dt-bindings: Add qcom spmi_pmic clock divider
 bindings
Message-ID: <20171204202959.6gxmy7jdt7gwspuh@rob-hp-laptop>
References: <1511255465-3984-1-git-send-email-tirupath@codeaurora.org>
 <1511255465-3984-3-git-send-email-tirupath@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1511255465-3984-3-git-send-email-tirupath@codeaurora.org>
User-Agent: NeoMutt/20170609 (1.8.3)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2339
Lines: 84

On Tue, Nov 21, 2017 at 02:41:05PM +0530, Tirupathi Reddy wrote:
> This patch adds device tree bindings for Qualcomm SPMI PMIC
> clock divider module.
> 
> Signed-off-by: Tirupathi Reddy <tirupath@codeaurora.org>
> ---
>  .../bindings/clock/qcom,spmi-pmic-div.txt          | 59 ++++++++++++++++++++++

Didn't Stephen say to move this somewhere else?

>  1 file changed, 59 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,spmi-pmic-div.txt
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,spmi-pmic-div.txt b/Documentation/devicetree/bindings/clock/qcom,spmi-pmic-div.txt
> new file mode 100644
> index 0000000..2cf2aba
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/qcom,spmi-pmic-div.txt
> @@ -0,0 +1,59 @@
> +Qualcomm Technologies, Inc. SPMI PMIC clock divider (clkdiv)
> +
> +clkdiv configures the clock frequency of a set of outputs on the PMIC.
> +These clocks are typically wired through alternate functions on
> +gpio pins.
> +
> +=======================
> +Properties
> +=======================
> +
> +- compatible
> +	Usage:      required
> +	Value type: <string>
> +	Definition: must be "qcom,spmi-clkdiv".
> +
> +- reg
> +	Usage:      required
> +	Value type: <prop-encoded-array>
> +	Definition: base address of CLKDIV peripherals.
> +
> +- qcom,num-clkdivs
> +	Usage:      required
> +	Value type: <u32>
> +	Definition: number of CLKDIV peripherals.
> +
> +- clocks:
> +	Usage: required
> +	Value type: <prop-encoded-array>
> +	Definition: reference to the xo clock.
> +
> +- clock-names:
> +	Usage: required
> +	Value type: <stringlist>
> +	Definition: must be "xo".
> +
> +- clock-cells:

#clock-cells

> +	Usage: required
> +	Value type: <u32>
> +	Definition: shall contain 1.
> +
> +=======
> +Example
> +=======
> +
> +pm8998_clk_divs: clock-controller@5b00 {
> +	compatible = "qcom,spmi-clkdiv";
> +	reg = <0x5b00>;
> +	#clock-cells = <1>;
> +	qcom,num-clkdivs = <3>;
> +	clocks = <&xo_board>;
> +	clock-names = "xo";
> +
> +	assigned-clocks = <&pm8998_clk_divs 1>,
> +			  <&pm8998_clk_divs 2>,
> +			  <&pm8998_clk_divs 3>;
> +	assigned-clock-rates = <9600000>,
> +			       <9600000>,
> +			       <9600000>;
> +};
> -- 
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
>