Subject: Re: [PATCH 0/5] blkcg: Limit maximum number of aio requests available
 for cgroup
To: Jeff Moyer <jmoyer@redhat.com>
Cc: Benjamin LaHaise <ben@communityfibre.ca>, axboe@kernel.dk,
        viro@zeniv.linux.org.uk, tj@kernel.org, linux-block@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-aio@kvack.org, oleg@redhat.com
References: <151240305010.10164.15584502480037205018.stgit@localhost.localdomain>
 <20171204165213.GF11494@kvack.org>
 <08b9cab6-5237-c027-3bf3-08a69de7fe41@virtuozzo.com>
 <x49indmw50k.fsf@segfault.boston.devel.redhat.com>
From: Kirill Tkhai <ktkhai@virtuozzo.com>
Message-ID: <4faaaeb9-a574-6443-4787-d42d724f0631@virtuozzo.com>
Date: Tue, 5 Dec 2017 00:48:17 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <x49indmw50k.fsf@segfault.boston.devel.redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2017 21:48:19.7292 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 86d7c74d-59be-478a-b956-08d53b60bcb9
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0bc7f26d-0264-416e-a6fc-8352af79c58f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1343
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2399
Lines: 70

On 05.12.2017 00:35, Jeff Moyer wrote:
> Kirill Tkhai <ktkhai@virtuozzo.com> writes:
> 
>> Hi, Benjamin,
>>
>> On 04.12.2017 19:52, Benjamin LaHaise wrote:
>>> Hi Kirill,
>>>
>>> On Mon, Dec 04, 2017 at 07:12:51PM +0300, Kirill Tkhai wrote:
>>>> Hi,
>>>>
>>>> this patch set introduces accounting aio_nr and aio_max_nr per blkio cgroup.
>>>> It may be used to limit number of aio requests, which are available for
>>>> a cgroup, and could be useful for containers.
>>>>
>>>> The accounting is hierarchical, and aio contexts, allocated in child cgroup,
>>>> are accounted in parent cgroups too.
>>>>
>>>> Also, new cgroup file "io.aio_nr" is introduced. It's used to set cgroup
>>>> aio requests limit, to show current limit and number of currenly occupied
>>>> requests.
>>>
>>> Where are your test cases to check this functionality in the libaio test
>>> suite?
>>
>> I tried to find actual libaio test suite repository url in google,
>> but there is no certain answer. Also, there is no information in kernel
>> anywhere (I hope I grepped right).
>>
>> Could you please provide url where actual upstream libaio could be obtained?
> 
> https://pagure.io/libaio
> 
> Patches can be sent to this list (linux-aio).
> 

Thank you, Jeff.

Kirill

>>>> Patches 1-3 are refactoring.
>>>> Patch 4 is the place where the accounting actually introduced.
>>>> Patch 5 adds "io.aio_nr" file.
>>>>
>>>> ---
>>>>
>>>> Kirill Tkhai (5):
>>>>       aio: Move aio_nr increment to separate function
>>>>       aio: Export aio_nr_lock and aio_max_nr initial value to include/linux/aio.h
>>>>       blkcg: Add blkcg::blkg_aio_nr and blkcg::blkg_aio_max_nr
>>>>       blkcg: Charge aio requests in blkio cgroup hierarchy
>>>>       blkcg: Add cgroup file to configure blkcg::blkg_aio_max_nr
>>>>
>>>>
>>>>  block/blk-cgroup.c         |   88 +++++++++++++++++++++++++-
>>>>  fs/aio.c                   |  151 ++++++++++++++++++++++++++++++++++++++++----
>>>>  include/linux/aio.h        |   21 ++++++
>>>>  include/linux/blk-cgroup.h |    4 +
>>>>  4 files changed, 247 insertions(+), 17 deletions(-)
>>>>
>>>> --
>>>> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
>>>>
>>>
>>
>> --
>> To unsubscribe, send a message with 'unsubscribe linux-aio' in
>> the body to majordomo@kvack.org.  For more info on Linux AIO,
>> see: http://www.kvack.org/aio/
>> Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>