Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752316AbdLDWuI (ORCPT ); Mon, 4 Dec 2017 17:50:08 -0500 Received: from esa5.hgst.iphmx.com ([216.71.153.144]:38014 "EHLO esa5.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752217AbdLDWuF (ORCPT ); Mon, 4 Dec 2017 17:50:05 -0500 X-IronPort-AV: E=Sophos;i="5.45,361,1508774400"; d="scan'208";a="64156398" From: Bart Van Assche To: "ming.lei@redhat.com" CC: "linux-kernel@vger.kernel.org" , "linux-block@vger.kernel.org" , "hch@infradead.org" , "martin.petersen@oracle.com" , "linux-scsi@vger.kernel.org" , "axboe@fb.com" , "hare@suse.com" , "jejb@linux.vnet.ibm.com" Subject: Re: [PATCH] SCSI: delay run queue if device is blocked in scsi_dev_queue_ready() Thread-Topic: [PATCH] SCSI: delay run queue if device is blocked in scsi_dev_queue_ready() Thread-Index: AQHTa4se686/KXegNkKe8Nuy2OdfsaMzTKCAgAB/WwCAAAFVAA== Date: Mon, 4 Dec 2017 22:49:55 +0000 Message-ID: <1512427794.2795.15.camel@wdc.com> References: <20171202163150.1273-1-ming.lei@redhat.com> <1512400159.23838.1.camel@wdc.com> <20171204224507.GB6888@ming.t460p> In-Reply-To: <20171204224507.GB6888@ming.t460p> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Bart.VanAssche@wdc.com; x-originating-ip: [199.255.44.171] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;CY1PR0401MB1536;20:TxL0L/kd8CsdoYW253wUwUlK1tZtjtHKigBi8Mx/KvT8DQyxkfjssSamQ/KSBniHBfJUOfypWAIpYCv0PYnTPEsuVaBAcPcWd5FWDO0IPNS+A/TyrLTYdUTKfk+evuUid35ti28nbn5MWGmLNlBgUWr2X958giFkaupTRIAaC90= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-correlation-id: 307ea99e-6706-42b5-8353-08d53b6956c7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(5600026)(4604075)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603286);SRVR:CY1PR0401MB1536; x-ms-traffictypediagnostic: CY1PR0401MB1536: wdcipoutbound: EOP-TRUE x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(2401047)(8121501046)(5005006)(10201501046)(3231022)(3002001)(93006095)(93001095)(6055026)(6041248)(20161123555025)(20161123558100)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123560025)(20161123562025)(20161123564025)(6072148)(201708071742011);SRVR:CY1PR0401MB1536;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:CY1PR0401MB1536; x-forefront-prvs: 051158ECBB x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39860400002)(366004)(376002)(346002)(189002)(199003)(377424004)(24454002)(229853002)(478600001)(68736007)(77096006)(66066001)(5640700003)(966005)(8676002)(6486002)(72206003)(6436002)(6506006)(99286004)(36756003)(81166006)(81156014)(97736004)(76176011)(6512007)(6306002)(3660700001)(15650500001)(2906002)(3280700002)(6246003)(25786009)(4326008)(86362001)(2501003)(53936002)(2351001)(102836003)(6116002)(5660300001)(3846002)(54356011)(33646002)(305945005)(8936002)(7736002)(2900100001)(54906003)(316002)(106356001)(103116003)(14454004)(2950100002)(105586002)(101416001)(189998001)(6916009)(6606295002);DIR:OUT;SFP:1102;SCL:1;SRVR:CY1PR0401MB1536;H:CY1PR0401MB1536.namprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-OriginatorOrg: wdc.com X-MS-Exchange-CrossTenant-Network-Message-Id: 307ea99e-6706-42b5-8353-08d53b6956c7 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Dec 2017 22:49:55.5063 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0401MB1536 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id vB4MoEPa027393 Content-Length: 720 Lines: 16 On Tue, 2017-12-05 at 06:45 +0800, Ming Lei wrote: > On Mon, Dec 04, 2017 at 03:09:20PM +0000, Bart Van Assche wrote: > > On Sun, 2017-12-03 at 00:31 +0800, Ming Lei wrote: > > > Fixes: 0df21c86bdbf ("scsi: implement .get_budget and .put_budget for blk-mq") > > > > It might be safer to revert commit 0df21c86bdbf instead of trying to fix all > > issues introduced by that commit for kernel version v4.15 ... > > What are all issues in v4.15-rc? Up to now, it is the only issue reported, > and can be fixed by this simple patch, which one can be thought as cleanup > too. The three issues I described in the commit message of the patch that is available at: https://marc.info/?l=linux-block&m=151240866010572. Bart.