Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752302AbdLDW6e (ORCPT ); Mon, 4 Dec 2017 17:58:34 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:36616 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752234AbdLDW62 (ORCPT ); Mon, 4 Dec 2017 17:58:28 -0500 X-Google-Smtp-Source: AGs4zMa2+nJivUHkJLoy7scXyxB6eQ4vFLhEk535pGBXve24wHoG8uB4G9xcj+vyg1du086HFmzUVw== Date: Mon, 4 Dec 2017 14:58:25 -0800 From: Tejun Heo To: Prateek Sood Cc: avagin@gmail.com, mingo@kernel.org, peterz@infradead.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, sramana@codeaurora.org Subject: Re: [PATCH] cgroup/cpuset: fix circular locking dependency Message-ID: <20171204225825.GP2421075@devbig577.frc2.facebook.com> References: <1511868946-23959-1-git-send-email-prsood@codeaurora.org> <623f214b-8b9a-f967-7a3d-ca9c06151267@codeaurora.org> <20171204202219.GF2421075@devbig577.frc2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20171204202219.GF2421075@devbig577.frc2.facebook.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 699 Lines: 23 Hello, again. On Mon, Dec 04, 2017 at 12:22:19PM -0800, Tejun Heo wrote: > Hello, > > On Mon, Dec 04, 2017 at 10:44:49AM +0530, Prateek Sood wrote: > > Any feedback/suggestion for this patch? > > Sorry about the delay. I'm a bit worried because it feels like we're > chasing a squirrel. I'll think through the recent changes and this > one and get back to you. Can you please take a look at the following pending commit? https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git/commit/?h=for-4.15-fixes&id=e8b3f8db7aad99fcc5234fc5b89984ff6620de3d AFAICS, this should remove the circular dependency you originally reported. I'll revert the two cpuset commits for now. Thanks. -- tejun