Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752294AbdLECAl (ORCPT ); Mon, 4 Dec 2017 21:00:41 -0500 Received: from mail-yw0-f195.google.com ([209.85.161.195]:38799 "EHLO mail-yw0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751934AbdLECAj (ORCPT ); Mon, 4 Dec 2017 21:00:39 -0500 X-Google-Smtp-Source: AGs4zMauwwd5cocBoAuB/pm3ZHhdztvF09b8qfBB/dT7BWoE04j5UmreT2Fi5ehr7xaPwFJI4xr6ow== Date: Mon, 4 Dec 2017 18:00:33 -0800 From: Eduardo Valentin To: Daniel Lezcano Cc: Leo Yan , rui.zhang@intel.com, jean.wangtao@linaro.org, Keerthy , "open list:THERMAL" , open list Subject: Re: [PATCH V2] thermal/drivers/hisi: Switch to interrupt mode Message-ID: <20171205020031.GA4949@localhost.localdomain> References: <1bfd974e-3dc1-e99b-d0dd-50102cee762d@ti.com> <1506575625-20388-1-git-send-email-daniel.lezcano@linaro.org> <20170928065752.GA31697@leoy-linaro> <20170928073220.GF2196@mai> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170928073220.GF2196@mai> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1370 Lines: 38 Hello, On Thu, Sep 28, 2017 at 09:32:20AM +0200, Daniel Lezcano wrote: > On Thu, Sep 28, 2017 at 02:57:52PM +0800, Leo Yan wrote: > > Hi Daniel, > > > > On Thu, Sep 28, 2017 at 07:13:44AM +0200, Daniel Lezcano wrote: > > > At this moment, we have both the interrupt setup and the polling enabled. The > > > interrupt does nothing more than forcing an update while the temperature is > > > polled every second. > > > > > > We can do much better than that, threshold is set to 65C in the DT and the > > > passive cooling device enters in the dance when 75C is reached. We need to > > > sample the temperature at 65C in order to let the IPA gather enough values for > > > the PID computation. If the SoC is running at a temperature below 65C, we will > > > be constantly polling for nothing. > > > > > > This patch disables the sensor when the temperature is below 65C and enables it > > > when passing the threshold. It results the thermal sensor driver will have no > > > activity most of the time. > > > > > > Cc: Keerthy > > > Cc: Leo Yang > > > > s/Yang/Yan :) Have tested this patch on Hikey at my side: > > Oops sorry :) > > > Reviewed-by: Leo Yan > > Tested-by: Leo Yan > Is this still needed after the latest rework done? > > Great! Thanks for testing. > > -- Daniel