Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752374AbdLEFEB (ORCPT ); Tue, 5 Dec 2017 00:04:01 -0500 Received: from mga11.intel.com ([192.55.52.93]:49783 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbdLEFD6 (ORCPT ); Tue, 5 Dec 2017 00:03:58 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,362,1508828400"; d="scan'208";a="13143899" Date: Tue, 5 Dec 2017 13:02:46 +0800 From: "Liu, Changcheng" To: paulmck@linux.vnet.ibm.com, mingo@kernel.org, tglx@linutronix.de, bigeasy@linutronix.de Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, changcheng.liu@intel.com Subject: [PATCH] kernel/stop_machine: fix (de)reference function pointer Message-ID: <20171205050246.GA81448@sofia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 500 Lines: 20 It's better to avoid ambiguity when (de)referencing function pointer. Signed-off-by: Liu Changcheng diff --git a/kernel/stop_machine.c b/kernel/stop_machine.c index b759126..121d6aa 100644 --- a/kernel/stop_machine.c +++ b/kernel/stop_machine.c @@ -577,7 +577,7 @@ int stop_machine_cpuslocked(cpu_stop_fn_t fn, void *data, local_irq_save(flags); hard_irq_disable(); - ret = (*fn)(data); + ret = fn(data); local_irq_restore(flags); return ret; -- 2.7.4