Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752434AbdLELTu (ORCPT ); Tue, 5 Dec 2017 06:19:50 -0500 Received: from mail-wr0-f195.google.com ([209.85.128.195]:46580 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752201AbdLELTq (ORCPT ); Tue, 5 Dec 2017 06:19:46 -0500 X-Google-Smtp-Source: AGs4zMaR4gAXIdrrcXezvbC/uE20jp1Z9B8v8R/LZZ1rpSzcIa3JEAHcEas8rpgHM73m0YURV580SA== From: Ben Whitten X-Google-Original-From: Ben Whitten To: rpurdie@rpsys.net, pavel@ucw.cz, jacek.anaszewski@gmail.com Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Ben Whitten Subject: [PATCH/RFC v2] leds: trigger: Introduce a NETDEV trigger Date: Tue, 5 Dec 2017 11:19:10 +0000 Message-Id: <1512472751-10928-1-git-send-email-ben.whitten@lairdtech.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1106 Lines: 26 From: Ben Whitten The patch was converted to led_blink_oneshot, in doing so we find that the behaviour has changed. As I dont want to break 'userspace' led behaviour this patch shouldn't be merged as is. Open to suggestions. Given an interval of 50ms and heavy throughput, the previous implementation produced a blink with 100ms period and 50% dutycycle. The led_blink_oneshot version produces a blink with 140ms period and 57% dutycycle. I assume a fudge factor on the oneshot delay to bring the period back to 100ms would be device specific so not suitable. Kind regards, Ben Whitten (1): leds: trigger: Introduce a NETDEV trigger .../ABI/testing/sysfs-class-led-trigger-netdev | 45 ++ drivers/leds/trigger/Kconfig | 7 + drivers/leds/trigger/Makefile | 1 + drivers/leds/trigger/ledtrig-netdev.c | 507 +++++++++++++++++++++ 4 files changed, 560 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-class-led-trigger-netdev create mode 100644 drivers/leds/trigger/ledtrig-netdev.c -- 2.7.4